Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Light simulation issue 4: Reproducibility #199

Open
YifanC opened this issue Feb 6, 2024 · 4 comments
Open

Light simulation issue 4: Reproducibility #199

YifanC opened this issue Feb 6, 2024 · 4 comments

Comments

@YifanC
Copy link
Collaborator

YifanC commented Feb 6, 2024

In my naive understanding, the randomness of the light simulation only comes from the detector noise. However, I am seeing some reproduciblility issues when looking for signals (any peaks). In general, the signals are around the same time and around the same channels with some variation. Taking one channel (ch 150) from simulating the second event of MiniRun5_1E19_RHC.convert2h5.00666.EDEPSIM.hdf5 as an example. The seed is not fixed but I don't think it affect it here...(will test again with fixed seed). Four repeats yield quite different results.
signal_ch150_MR5_666_rp4
signal_ch150_MR5_666_rp3
signal_ch150_MR5_666_rp2
signal_ch150_MR5_666_rp1

Tag @mjkramer @krwood @liviocali @AWh1t3 for comments

@liviocali
Copy link
Member

There is a randomness in the light simulation: The for the number of photons we apply a poisson smearing based on the calculated incidence. See

def calc_stat_fluctuations(light_sample_inc, light_sample_inc_disc, rng_states):

@AWh1t3
Copy link
Member

AWh1t3 commented Feb 6, 2024

Is it a little weird, Livio, that one of Yifan's events has no peak at all? I understand we want poisson fluctuations for the number of PE per time tick, but that one just looks like the light was completely deleted.

@krwood
Copy link
Member

krwood commented Feb 6, 2024

In principle, the random number from the poisson sample should be reproducible if we fix the seed. This was also observed not to be the case in the charge simulation, as in Issue #125

@YifanC
Copy link
Collaborator Author

YifanC commented Feb 6, 2024

Will test with fixed seed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants