You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I think one of the reason larndsim readability is low is that when we define intermediate data, we uses shape of previous intermediate data, for example here (instead of using len(unique_pix), we use pixels_signals.shape[0])
Suggestions:
Add comments
Explicitly define the intermediate data type
Enforce consistency check
The text was updated successfully, but these errors were encountered:
I think one of the reason larndsim readability is low is that when we define intermediate data, we uses shape of previous intermediate data, for example here (instead of using len(unique_pix), we use pixels_signals.shape[0])
Suggestions:
The text was updated successfully, but these errors were encountered: