Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Event t0 #109

Open
YifanC opened this issue Feb 23, 2024 · 1 comment
Open

Event t0 #109

YifanC opened this issue Feb 23, 2024 · 1 comment

Comments

@YifanC
Copy link
Collaborator

YifanC commented Feb 23, 2024

When we use SymmetricWindowRawEventBuilder , if there's no external trigger, the time of the first arrival hit is considered as event t0, which can be horrendously wrong.

  1. Shall we explicitly label events without external triggers downstream from the flow stage?
  2. It might not be good idea, but for cathode crossing events, shall we try stitching the hits at the cathode and consider that as the t0?
evt7 evt10
@krwood
Copy link
Member

krwood commented Feb 23, 2024

Yes, in general we should add a field to the charge/event object that tags which event builder built the particular event. Then for 2x2 we first run over with the beam trigger event builder, make all the events we can, and tag them as beam trigger events. And then, e.g., run over the remaining packets and build as many LRS threshold trigger events as we can, and tag them as threshold trigger events. And then another pass with something like the symmetric window event builder, and tag them as such. Etc.

Side note: for events like the ones you have in the attached event displays, it’s possible that we could still match this with a light event and correct the event time with the associated t0. I guess this would mostly occur when there is some inefficiency in the pacman receiving the threshold trigger signal from LRS. In principle, this shouldn’t happen, but I seem to remember this happening in the single module runs in some instances. (We should try and catch this in DQM.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants