Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[0.6] Stacking with keyboard shortcut bug #58

Open
highvoltaged opened this issue Jul 25, 2018 · 6 comments
Open

[0.6] Stacking with keyboard shortcut bug #58

highvoltaged opened this issue Jul 25, 2018 · 6 comments
Labels
bug Something isn't working enhancement New feature or request fixed for next release The fix will be included in the next release

Comments

@highvoltaged
Copy link

highvoltaged commented Jul 25, 2018

Uploaded a test file:
https://www.dropbox.com/s/yvehqryq2yf5dqc/PADDY%20BUG%20KEYBOARD.sketch?dl=0

Just select all the 3 groups and press the stacking shortcut.
It will start with a negative number, and you can't press cancel, the window stays there.

Expected result:
Paddy takes the values from the first selected group, and opens the window with that.
Like in paddy 1

Thanks

@highvoltaged highvoltaged changed the title Stacking wi [0.6] Stacking with keyboard shortcut bug Jul 25, 2018
@highvoltaged
Copy link
Author

Update:
You generally cannot quit form the shortcut windows. Neither from stacking nor padding.
Cancel and ESC wont work.

@highvoltaged
Copy link
Author

After further testing i think i know where this originates from.
The new behaviour in Paddy 2 is that if you click on Add stacking, it will automatically group and stack selected objects, as opposed to Paddy1 where it only worked on already grouped objects.

I understand the good side of this, so you can much quicker stack things without grouping them first, but this way you cant select and modify multiple stackings, like in Paddy1. I use that function a lot, so it would be great to have both options somehow available.

@highvoltaged
Copy link
Author

Maybe if its possible, if you select multiple already stacked objects, a new menu appears on the inspector panel, called "Edit Stackings" under "Stack layers""
Just an idea

@DWilliames
Copy link
Owner

DWilliames commented Jul 25, 2018

Great find @highvoltaged. Thank you 👍

So to summarise those couple of things:

  • Bug: Cancel / ESC not working on both Padding / Stacking windows (Oops 🙃)
  • Consistency issue: Selecting multiple existing Stack Groups should default to 'updating their values' in the Stacking Window prompt – rather than creating a new group
  • Enhancement: Create an option to toggle between 'creating' / 'updating' stack group, based on selection

Really appreciate you logging these 👍

@DWilliames DWilliames added bug Something isn't working enhancement New feature or request In progress Currently being worked on / investigated fixed for next release The fix will be included in the next release and removed In progress Currently being worked on / investigated labels Jul 25, 2018
@DWilliames
Copy link
Owner

This is fixed for the next release.
I added a toggle for 'Create' / 'Update' in the Stack Group prompt window.
However, I haven't added it in the inspector yet. I might park that one for now, and do it later, because it's a bit trickier 👍

@highvoltaged
Copy link
Author

Great,many thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request fixed for next release The fix will be included in the next release
Projects
None yet
Development

No branches or pull requests

2 participants