From 0a01cc6e0c82d449afa02e1190483e68716df333 Mon Sep 17 00:00:00 2001
From: 101 <tmddnjs001133@dsm.hs.kr>
Date: Sat, 16 Mar 2024 21:12:52 +0900
Subject: [PATCH] refactor UpdateDocument.java

---
 .../component/service/UpdateDocument.java         | 15 ++++++++-------
 1 file changed, 8 insertions(+), 7 deletions(-)

diff --git a/src/main/java/com/example/daemawiki/domain/document/component/service/UpdateDocument.java b/src/main/java/com/example/daemawiki/domain/document/component/service/UpdateDocument.java
index d7532786..51698914 100644
--- a/src/main/java/com/example/daemawiki/domain/document/component/service/UpdateDocument.java
+++ b/src/main/java/com/example/daemawiki/domain/document/component/service/UpdateDocument.java
@@ -2,7 +2,6 @@
 
 import com.example.daemawiki.domain.common.UserFilter;
 import com.example.daemawiki.domain.document.component.UpdateDocumentComponent;
-import com.example.daemawiki.domain.document.component.UpdateDocumentEditorAndUpdatedDate;
 import com.example.daemawiki.domain.document.component.facade.DocumentFacade;
 import com.example.daemawiki.domain.document.dto.request.SaveDocumentRequest;
 import com.example.daemawiki.domain.document.model.DefaultDocument;
@@ -17,6 +16,7 @@
 import com.example.daemawiki.global.exception.h500.ExecuteFailedException;
 import org.springframework.stereotype.Service;
 import reactor.core.publisher.Mono;
+import reactor.util.function.Tuple2;
 
 @Service
 public class UpdateDocument {
@@ -39,17 +39,18 @@ public UpdateDocument(DocumentFacade documentFacade, UserFacade userFacade, GetD
     public Mono<Void> execute(SaveDocumentRequest request, String documentId) {
         return userFacade.currentUser()
                 .zipWith(documentFacade.findDocumentById(documentId))
-                .map(tuple -> {
-                    userFilter.userPermissionAndDocumentVersionCheck(tuple.getT2(), tuple.getT1().getEmail(), request.version());
-                    return tuple;
-                })
-                .map(tuple -> setDocument(tuple.getT2(), tuple.getT1(), request))
+                .map(tuple -> checkPermissionAndUpdateDocument(tuple, request))
                 .flatMap(document -> documentFacade.saveDocument(document)
                                 .then(createRevision(document)))
                 .onErrorMap(this::mapException);
     }
 
-    private DefaultDocument setDocument(DefaultDocument document, User user, SaveDocumentRequest request) {
+    private DefaultDocument checkPermissionAndUpdateDocument(Tuple2<User, DefaultDocument> tuple, SaveDocumentRequest request) {
+        DefaultDocument document = tuple.getT2();
+        User user = tuple.getT1();
+
+        userFilter.userPermissionAndDocumentVersionCheck(document, user.getEmail(), request.version());
+
         document.update(request.title(),
                 getDocumentType.execute(request.type().toLowerCase()),
                 request.groups());