-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add constructor of PERK3 #21
Add constructor of PERK3 #21
Conversation
Review checklistThis checklist is meant to assist creators of PRs (to let them know what reviewers will typically look for) and reviewers (to guide them in a structured review process). Items do not need to be checked explicitly for a PR to be eligible for merging. Purpose and scope
Code quality
Documentation
Testing
Performance
Verification
Created with ❤️ by the Trixi.jl community. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot! I left some minor comments going beyond pure functionality.
src/time_integration/paired_explicit_runge_kutta/methods_PERK3.jl
Outdated
Show resolved
Hide resolved
src/time_integration/paired_explicit_runge_kutta/methods_PERK3.jl
Outdated
Show resolved
Hide resolved
src/time_integration/paired_explicit_runge_kutta/methods_PERK3.jl
Outdated
Show resolved
Hide resolved
src/time_integration/paired_explicit_runge_kutta/methods_PERK3.jl
Outdated
Show resolved
Hide resolved
src/time_integration/paired_explicit_runge_kutta/methods_PERK3.jl
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Warisa! Couple more requested changes related to the comments. Note that in Trixi we use a whitespace
after the comment escape symbol: #
.
src/time_integration/paired_explicit_runge_kutta/methods_PERK3.jl
Outdated
Show resolved
Hide resolved
src/time_integration/paired_explicit_runge_kutta/methods_PERK3.jl
Outdated
Show resolved
Hide resolved
src/time_integration/paired_explicit_runge_kutta/methods_PERK3.jl
Outdated
Show resolved
Hide resolved
src/time_integration/paired_explicit_runge_kutta/methods_PERK3.jl
Outdated
Show resolved
Hide resolved
src/time_integration/paired_explicit_runge_kutta/methods_PERK3.jl
Outdated
Show resolved
Hide resolved
src/time_integration/paired_explicit_runge_kutta/methods_PERK3.jl
Outdated
Show resolved
Hide resolved
src/time_integration/paired_explicit_runge_kutta/methods_PERK3.jl
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Warisa!
6436708
into
DanielDoehring:PERK_p2p3_Single
No description provided.