Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

There are some mistake in this web program #6

Open
shangke1988 opened this issue May 29, 2017 · 10 comments
Open

There are some mistake in this web program #6

shangke1988 opened this issue May 29, 2017 · 10 comments

Comments

@shangke1988
Copy link
Contributor

There are some mistake in this web program. Such as, the land and water of Eve use the same science. The science of Biome are also displayed in Global.
I have correct these bugs and update for KSP 1.3.
I recommend the sort in the program, so I can manually use the order in WIKI.
But I don't how to upload.
There is my test web http://shangke1988.win:8080/ksp/my_science_remaining/.

@DanielVF
Copy link
Owner

DanielVF commented May 29, 2017

Thanks. I'd love to have your updates. If I just copy over all_science.csv, is that all I need? Or did you update the code/data that generates all_science.csv.

@shangke1988
Copy link
Contributor Author

shangke1988 commented May 30, 2017

Updating all_science.csv can do most part.
1.I have updated .tsv files for KSP1.3.
2.I have updated all_science.rb for some bugs.
3.I have added infrared telescop to science_department.js
4.I add a progress bar into views.js for each biome.
Should I create a fork first?

@shangke1988
Copy link
Contributor Author

I have created a fork.
https://github.com/shangke1988/kerbal_science_remaining

@DanielVF
Copy link
Owner

Fantastic! I've merged that in. Thanks so much! I'll update my site with it next.

@shangke1988
Copy link
Contributor Author

I'm sorry. I forget the all_science.csv.
I used jruby, and there are many .999999999 in my data.

@DanielVF
Copy link
Owner

I've pulled your latest all_science.csv. Thanks!

I've also updated the site, although it looks like amazon is caching the wrong version of the stylesheet. Hopefully that clears up in a few.

@DanielVF
Copy link
Owner

I've registered a domain and moved the site to http://www.kerbal-science.com/ . Looks like everything is working.

@shangke1988
Copy link
Contributor Author

shangke1988 commented May 30, 2017 via email

@shangke1988
Copy link
Contributor Author

In order to Refresh, clean the buffer memory of chrome is usefull.

@shangke1988
Copy link
Contributor Author

I add science of Craft recovery now.
And correct some bugs.
add log in console for calculating wrong data.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants