Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dgCMatrix Support for get.exp.stat function #110

Open
Cosmic1Neko opened this issue Jan 13, 2025 · 0 comments
Open

dgCMatrix Support for get.exp.stat function #110

Cosmic1Neko opened this issue Jan 13, 2025 · 0 comments

Comments

@Cosmic1Neko
Copy link

Cosmic1Neko commented Jan 13, 2025

Hello,
Thank you for this amazing package!
The current implementation of the get.exp.stat function can be inefficient when dealing with sparse matrices (dgCMatrix). Specifically, the line:

dat.tmp <- log2(dat.tmp + pseudo.count) - log2(pseudo.count)

If modified to the following code, it can avoid converting the dgCMatrix to a dense matrix when the input is a dgCMatrix:

dat.tmp@x <- log2(dat.tmp@x + pseudo.count) - log2(pseudo.count) 

Thank you for considering this suggestion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant