Skip to content

Commit

Permalink
add temp fix since no proper fix exist at the moment
Browse files Browse the repository at this point in the history
  • Loading branch information
xMasterX committed May 1, 2024
1 parent a57dbe4 commit 75ece9b
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 2 deletions.
6 changes: 5 additions & 1 deletion lib/nfc/helpers/iso14443_4_layer.c
Original file line number Diff line number Diff line change
Expand Up @@ -66,9 +66,13 @@ bool iso14443_4_layer_decode_block(

bool ret = false;

// TODO: Fix properly! this is a very big kostyl na velosipede
// (bit_buffer_copy_right are called to copy bigger buffer into smaller buffer causing crash on furi check) issue comes iso14443_4a_poller_send_block at line 109
if(bit_buffer_get_size_bytes(output_data) < bit_buffer_get_size_bytes(output_data) - 1)
return ret;

do {
if(!bit_buffer_starts_with_byte(block_data, instance->pcb_prev)) break;
// TODO: Fix crash
bit_buffer_copy_right(output_data, block_data, 1);
ret = true;
} while(false);
Expand Down
1 change: 0 additions & 1 deletion lib/toolbox/bit_buffer.c
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,6 @@ void bit_buffer_copy_right(BitBuffer* buf, const BitBuffer* other, size_t start_
furi_check(buf);
furi_check(other);
furi_check(bit_buffer_get_size_bytes(other) > start_index);
// TODO: Fix crash
furi_check(buf->capacity_bytes >= bit_buffer_get_size_bytes(other) - start_index);

memcpy(buf->data, other->data + start_index, bit_buffer_get_size_bytes(other) - start_index);
Expand Down

0 comments on commit 75ece9b

Please sign in to comment.