Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NV56TU code does not build (reported in DM by Theirry) #1139

Open
pietrushnic opened this issue Nov 14, 2024 · 5 comments
Open

NV56TU code does not build (reported in DM by Theirry) #1139

pietrushnic opened this issue Nov 14, 2024 · 5 comments
Assignees
Labels
bug Something isn't working firmware needs review novacustom_v56_mtl NovaCustom V56 Series

Comments

@pietrushnic
Copy link

Component

Dasharo firmware

Device

NovaCustom V56 14th Gen

Dasharo version

v0.9.0

Dasharo Tools Suite version

No response

Test case ID

No response

Brief summary

Commit reference config points to bad FSP paths, no recipe to build EC

How reproducible

I'm unsure; I'm just reporting what Thierry sent me in DM. I assume it should 100%.

linuxboot/heads#1835

How to reproduce

Try to build https://docs.dasharo.com/variants/novacustom_v560tu/releases/#v090-2024-07-18

Expected behavior

Dasharo (coreboot+UEFI) builds correctly based on the provided information in the release.

Actual behavior

No sure, no logs, no error messages received. Someone has to try to reproduce that and confirm this is valid.I'm not sure. No logs, no error messages were

Screenshots

No response

Additional context

It blocks Heads development. From Thierry:

  • reference config does not point to proper FSP header and other paths are wrong (untested?)
  • FMP will need to be redefined since there is no contiguous free space in firmware (we need 7.5mb for payload in CBFS, and all other free space), never had to write up/modify FMP before where ifd in tree cannot be parsed with ifdtool
  • ec is not built by Heads, need code there under modules/coreboot as contribution (patch)

I see linuxboot/heads#1846 changing used coreboot fork commit to accomodate same kind of issues discovered by mkopec.

Solutions you've tried

No response

@tlaurion
Copy link

tlaurion commented Nov 14, 2024

To validate this, defconfig needs to be expended into ooldconfig. Here I can only refer to what is under defconfig of ref config at
https://github.com/Dasharo/coreboot/blob/316f964cb0f892ad4fe985b16c598f1e5ed8fe61/configs/config.novacustom_v560tu

TLDR: code, paths + reference config needs to build under Heads and then Heads features tested on my side under linuxboot/heads#1835

@tlaurion

This comment was marked as off-topic.

@macpijan
Copy link
Contributor

@mkopec is it already resolved in: linuxboot/heads#1846 ?
Can you please clarify what was the problem here?

@mkopec
Copy link
Member

mkopec commented Nov 19, 2024

FSP paths

Needed to change path from novacustom-blobs (private) to dasharo-blobs (public). The FSPs themselves are the same.

EC firmware

Probably need to add a new step in CI, but this is the first release, so I'm not sure if EC FW needs to be included

CBFS_SIZE + IFD/FIT tables need to work with CBFS >= 8MB so payload can be stitched in.

Not sure about this one, so far I've managed to build coreboot with LPSS UART for debugging. coreboot logs end with jumping to payload, but nothing happens afterwards (on console or on screen)

@tlaurion
Copy link

tlaurion commented Nov 20, 2024

linuxboot/heads#1846 (comment)

@mkopec

mkc: seems like kernel 6.7+ is bare minimal for meteor lake, with efifb fixes having landed under 6.8+?

Also, if you pass serial to kernel boot options under coreboot config, you should get logs of the kernel?

At https://matrix.to/#/!pAlHOfxQNPXOgFGTmo:matrix.org/$bVtsV3M_sz0MroFsDkXRGQ3ow7OhumKqtAllchkAyKs?via=matrix.org&via=nitro.chat&via=envs.net

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working firmware needs review novacustom_v56_mtl NovaCustom V56 Series
Projects
None yet
Development

No branches or pull requests

4 participants