Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HCA DX] Filter by atlas #3341

Open
Tracked by #3340
MillenniumFalconMechanic opened this issue May 4, 2023 · 5 comments
Open
Tracked by #3340

[HCA DX] Filter by atlas #3341

MillenniumFalconMechanic opened this issue May 4, 2023 · 5 comments
Assignees
Labels
canary Done by the Clever Canary team

Comments

@MillenniumFalconMechanic
Copy link
Contributor

MillenniumFalconMechanic commented May 4, 2023

Need

Add an Atlas filter and Atlas column to the project index page.

Approach

See mocks:

image
  • Map the atlas filter to termFacets.tissueAtlas in the /projects response from Azul.
  • Map the atlas column to hits.projects.tissueAtlas in the projects response from Azul; display as ${tissueAtlas.atlas} ${tissueAtlas.version}.
  • Add a new group to the top of the filters called "Atlas"; add Atlas and Biological Network to this group.
  • Filter display name is Altas (not Atlases in current branch).
  • Filter values are ${atlas} ${version} values pulled from tissueAtlas.
  • Filter request parameter format is filters={"tissueAtlas":{"is":[{"atlas": "Lung", "version": "v1.0"}]}} (and not the standard filters={"tissueAtlas":{"is":["Lung"]}}). For example, this request.
  • See the Tracker app for an example of including an icon in a cell value.

Notes

  • Functionality started on jonah/3341-hca-dx-filter-by-atlas branch with corresponding draft PR. (See Slack.)
@github-actions github-actions bot added the canary Done by the Clever Canary team label May 4, 2023
@MillenniumFalconMechanic MillenniumFalconMechanic changed the title [DX] Filter by atlas [HCA DB] Filter by atlas May 4, 2023
@MillenniumFalconMechanic MillenniumFalconMechanic changed the title [HCA DB] Filter by atlas [HCA DX] Filter by atlas Aug 29, 2024
@jpaten
Copy link
Contributor

jpaten commented Sep 1, 2024

Hi @MillenniumFalconMechanic! Should the new Atlases column be visible by default, or should it be hidden?

@jpaten
Copy link
Contributor

jpaten commented Sep 1, 2024

Also, since the filters on the mock don't match the current groups present on the dev site, what categoryGroup should the Atlas filter fall under?

@MillenniumFalconMechanic
Copy link
Contributor Author

Should the new Atlases column be visible by default, or should it be hidden?

what categoryGroup should the Atlas filter fall under

Hi @jpaten, thank you for these q's! I have updated the task description above.

@NoopDog
Copy link
Collaborator

NoopDog commented Nov 8, 2024

Hi @frano-m, can you add what is blocking this on the ticket? Thanks!

@MillenniumFalconMechanic
Copy link
Contributor Author

MillenniumFalconMechanic commented Nov 12, 2024

termFacets.tissueAtlas is missing version information:

image

Version information is however included in hits.projects.tissueAtlas:

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
canary Done by the Clever Canary team
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants