Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HCA DX] Track clicks on export request buttons #4191

Open
9 of 11 tasks
MillenniumFalconMechanic opened this issue Oct 11, 2024 · 8 comments · Fixed by #4201
Open
9 of 11 tasks

[HCA DX] Track clicks on export request buttons #4191

MillenniumFalconMechanic opened this issue Oct 11, 2024 · 8 comments · Fixed by #4201
Assignees
Labels
canary Done by the Clever Canary team

Comments

@MillenniumFalconMechanic
Copy link
Contributor

MillenniumFalconMechanic commented Oct 11, 2024

Need

We need to track clicks on export buttons such as "Request Link" for export to Terra, and "Prepare Manifest" for file manifest.

Approach

Investigate reuse of curl download event. See comments below for approach.

Definition of Done

Needs

Validation

curl Command

  • data.humancellatlas.org - GA4
  • data.humancellatlas.dev.clevercanary.com - GA4

File Manifest

  • data.humancellatlas.org - GA4
  • data.humancellatlas.dev.clevercanary.com - GA4

Export to Terra

  • data.humancellatlas.org - GA4
  • data.humancellatlas.dev.clevercanary.com - GA4
@github-actions github-actions bot added the canary Done by the Clever Canary team label Oct 11, 2024
@MillenniumFalconMechanic MillenniumFalconMechanic changed the title [HCA DX] Track clicks on export method buttons [HCA DX] Track clicks on export buttons Oct 11, 2024
@jpaten
Copy link
Contributor

jpaten commented Oct 16, 2024

Hi @MillenniumFalconMechanic! I took a look through the existing bulk_download_requested event, and I think it could be reused, but I found several issues that would need to be considered:

  • A new parameter for export_type would need to be added, containing info about the tool being used (e.g. curl_command, terra, etc.)
  • The current_query parameter contains the full JSON query, but frequently gets cut off due to GA4's character limits. This could be addressed by instead passing a parameter containing only the options selected on the export form (e.g. file format, species) and extracting the selected filter from the fullPageUrl dimension, which is collected by default and has a much higher character limit, since the filter is included in the URL.
  • The existing event would not be useful for backpage exports, since the event does not contain any info about the ID of the selected project/workspace but does include info about the entity the export is being made from in the index field. It would probably make sense to create a new event to track backpage exports
  • The existing parameter for index could be renamed to entity_name, to match other events
  • The tool_name parameter, which has a value of either bash or cmd.exe, only makes sense for Curl downloads. It could be deprecated or passed a null value for other tools
  • The catalog parameter may not be useful since events are already tracked separately for different sites, and it may be worth deprecating.

Let me know if you what you think about this, and I can make a findable ticket to add these changes and call the event on other existing events

@MillenniumFalconMechanic
Copy link
Contributor Author

MillenniumFalconMechanic commented Oct 16, 2024

  • Model exports separately (e.g. build_download_requested, file_manifest_requested).
  • Use page URL rather than current_query.
  • Back pages will have a separate event.
  • No custom params/dimensions for Species, File Type, Download Format etc.
  • Remove catalog param.
  • Make tool_name optional?
  • Update index to entity_name.

@MillenniumFalconMechanic
Copy link
Contributor Author

MillenniumFalconMechanic commented Oct 24, 2024

Hi @jpaten, the corresponding PR has been merged and deployed to dev.

@jpaten
Copy link
Contributor

jpaten commented Oct 25, 2024

Thanks @MillenniumFalconMechanic!

@jpaten
Copy link
Contributor

jpaten commented Oct 25, 2024

@MillenniumFalconMechanic I'm so sorry, I realized I mistagged the corresponding PR #4201 , which should have been associated with #4181! This shouldn't require any action though, because this ticket does not require any code changes to the data-browser repo. The only code changes are in DataBiosphere/findable-ui#224. Once that's reviewed, I'll go ahead and create a GTM version for this ticket, and comment it here. So sorry again for the confusion!

@MillenniumFalconMechanic
Copy link
Contributor Author

Hi @jpaten, Findable 14.0.0 has been deployed to dev. Can you continue with the configuration and testing against dev while we wait for the prod deploy?

@jpaten
Copy link
Contributor

jpaten commented Nov 13, 2024

Hi @MillenniumFalconMechanic! Yep, I can do that

@jpaten
Copy link
Contributor

jpaten commented Nov 15, 2024

Version #62 on GTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
canary Done by the Clever Canary team
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants