Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HCA DX] Update naming convention of export method-related tags and triggers #4272

Open
MillenniumFalconMechanic opened this issue Nov 15, 2024 · 4 comments
Assignees
Labels
canary Done by the Clever Canary team

Comments

@MillenniumFalconMechanic
Copy link
Contributor

Need

GTM tags and triggers related to selecting cohort export methods should follow the naming convention ${gtmObjectType} - index_${exportName}_selected. For example, tag - index_analyze_in_terra_selected or trigger - index_bulk_download_selected.

@github-actions github-actions bot added the canary Done by the Clever Canary team label Nov 15, 2024
@jpaten
Copy link
Contributor

jpaten commented Nov 20, 2024

  • Rename export_data_click to export_data_clicked
  • Rename outbound_link_click to outbound_link_clicked
  • Rename index_${exportType}_export_method to index_${exportType}_selected

@jpaten
Copy link
Contributor

jpaten commented Nov 22, 2024

Hi @MillenniumFalconMechanic! Here are the versions for your review

@MillenniumFalconMechanic
Copy link
Contributor Author

Hi @jpaten! It looks like AnVIL Portal needs to have its trigger updated but everything else LGTM. Thank you!

@jpaten
Copy link
Contributor

jpaten commented Nov 26, 2024

Updated AnVIL Portal as Version 22

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
canary Done by the Clever Canary team
Projects
None yet
Development

No branches or pull requests

2 participants