fix security bug

DataBiosphere · Aug 24, 2023 · 35af4ea · 35af4ea
1 parent a97a7c2
commit 35af4ea
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 6 deletions.
diff --git a/library/src/main/java/bio/terra/pfb/PfbReader.java b/library/src/main/java/bio/terra/pfb/PfbReader.java
@@ -104,11 +104,9 @@ public Metadata getPFBMetadata(String fileLocation) throws IOException {
       // Assuming the first object is the metadata object
       data = dataFileReader.next(data);
       result = (Metadata) data.getObject();
-    } catch (IOException e) {
-      e.printStackTrace();
-    }
-    if (result != null) {
-      return result;
+      if (result != null) {
+        return result;
+      }
     }
     throw new InvalidPfbException("Error reading PFB Metadata object");
   }

diff --git a/library/src/test/java/bio/terra/pfb/utils/CompareOutputUtils.java b/library/src/test/java/bio/terra/pfb/utils/CompareOutputUtils.java
@@ -79,7 +79,7 @@ public static void compareJSONLineByLine(
       }
       fileReader.close();
     } catch (IOException e) {
-      e.printStackTrace();
+      System.out.println("Error reading file: " + fileName);
     }
   }