Pull Requests

Required Approvals

Pull requests must be approved by at least two people. At least one of those reviews must be from a member of the Terra UI Code Owners group. A reviewer from this group will be automatically assigned when a PR is opened. Generally, the other reviewer would be someone from the PR author's team.

Tests

Integration tests against the dev environment will automatically be run when a branch is pushed. Currently, branch protection rules do not require tests to pass in order for a PR to be merged. However, the general expectation is that tests should pass before merging. In the case of flaky test failures that are apparently unrelated to the PR, re-running the tests a few times is preferred over merging with failing tests.

Occasionally, a change in dev causes one or more tests to consistently fail. Usually these are announced in the terra-ui Slack channel. In these cases, it's ok to merge a PR with those tests failing. If an apparently unrelated test consistently fails on a PR after a few re-runs, post in the terra-ui Slack channel.

Other Requirements and Guidelines