Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE]: Custom Span Tags for SQL Spans #6679

Open
jwyza-pi opened this issue Feb 18, 2025 · 1 comment
Open

[FEATURE]: Custom Span Tags for SQL Spans #6679

jwyza-pi opened this issue Feb 18, 2025 · 1 comment
Labels
type:enhancement Improvement to an existing feature

Comments

@jwyza-pi
Copy link

Framework or Library Name

No response

Library Type

No response

Library Version(s)

No response

Describe the feature you'd like

Presently SQL spans are generated by what appears to be site call interceptions. This means that, as far as I can tell, we lack the ability to modify those spans in any way. Specifically we lack the ability to add custom tags using Tracer.Instance.ActiveScope.Span.SetTag. Given that, would it be possible to do something like adding the ability to inject tags for the span based on something inside the query itself? Thinking something like specialized comments:

-- spantag:mytagname1:mytagvalue1
-- spantag:foo:bar

SELECT * FROM MyTable WHERE Id = @id

Is your feature request related to a problem?

No response

Describe alternatives you've considered

No response

Additional context

No response

@jwyza-pi jwyza-pi added the type:enhancement Improvement to an existing feature label Feb 18, 2025
@bouwkast
Copy link
Contributor

Hi @jwyza-pi,

Thanks a bunch for filing this, I'm thinking that this would be best handled by being routed as a Feature Request via our Helpdesk.

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:enhancement Improvement to an existing feature
Projects
None yet
Development

No branches or pull requests

2 participants