Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(profiling): update relnote for endpoint stack v2 [backport 2.14] #10981

Merged
merged 2 commits into from
Oct 10, 2024

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Oct 8, 2024

Backport cd1753d from #10962 to 2.14.

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

## Checklist
- [x] PR author has checked that all the criteria below are met
- The PR description includes an overview of the change
- The PR description articulates the motivation for the change
- The change includes tests OR the PR description describes a testing
strategy
- The PR description notes risks associated with the change, if any
- Newly-added code is easy to change
- The change follows the [library release note
guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html)
- The change includes or references documentation updates if necessary
- Backport labels are set (if
[applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting))

## Reviewer Checklist
- [ ] Reviewer has checked that all the criteria below are met
- Title is accurate
- All changes are related to the pull request's stated goal
- Avoids breaking
[API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces)
changes
- Testing strategy adequately addresses listed risks
- Newly-added code is easy to change
- Release note makes sense to a user of the library
- If necessary, author has acknowledged and discussed the performance
implications of this PR as reported in the benchmarks PR comment
- Backport labels are set in a manner that is consistent with the
[release branch maintenance
policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)

(cherry picked from commit cd1753d)
@github-actions github-actions bot requested a review from a team as a code owner October 8, 2024 16:31
@github-actions github-actions bot added changelog/no-changelog A changelog entry is not required for this PR. Profiling Continous Profling labels Oct 8, 2024
@pr-commenter
Copy link

pr-commenter bot commented Oct 8, 2024

Benchmarks

Benchmark execution time: 2024-10-09 19:45:09

Comparing candidate commit 20b5a16 in PR branch backport-10962-to-2.14 with baseline commit 3cada65 in branch 2.14.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 357 metrics, 47 unstable metrics.

@taegyunkim taegyunkim closed this Oct 8, 2024
@taegyunkim taegyunkim reopened this Oct 8, 2024
Copy link
Contributor Author

github-actions bot commented Oct 8, 2024

CODEOWNERS have been resolved as:

releasenotes/notes/profiling-fix-stack-v2-endpoint-82a1e26366166b8d.yaml  @DataDog/apm-python

@taegyunkim taegyunkim enabled auto-merge (squash) October 9, 2024 00:00
@taegyunkim taegyunkim merged commit e583f98 into 2.14 Oct 10, 2024
554 checks passed
@taegyunkim taegyunkim deleted the backport-10962-to-2.14 branch October 10, 2024 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog A changelog entry is not required for this PR. Profiling Continous Profling
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants