Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(rq): handle new Job.get_status() exception #11512

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

fancyweb
Copy link

Fixes #7985 again with rq 2.0.0.

rq 2.0.0 has been released about four weeks ago.

Since rq/rq#2039, Job.get_status() doesn't return None but raises InvalidJobOperation when refresh=True (which is the default behavior).

The proposed change is retro-compatible with previous supported versions.

I manually bumped rq latest to 2.0.0 since it's currently untested.

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

span_tags = {"job.status": job.get_status() or "None", "job.origin": job.origin}
try:
status = job.get_status()
except Exception:
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Catching all exceptions looks safer to avoid similar problems in the future.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better be safe since rq itself did not handle the new error well, which means using ddtrace-run currently makes the workers crash in such a scenario (see rq/rq#2154 (comment))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rq integration logs an exception when tracing a job with result_ttl=0
1 participant