Skip to content

Commit

Permalink
Update guard rails and doc (Excluding 3.4 installation)
Browse files Browse the repository at this point in the history
  • Loading branch information
TonyCTHsu committed Nov 21, 2024
1 parent 0dec342 commit 36af0b4
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 4 deletions.
3 changes: 2 additions & 1 deletion .gitlab-ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,8 @@ install-dependencies:
tags: [ "arch:$ARCH" ]
parallel:
matrix:
- RUBY_VERSION: ["3.4", "3.3", "3.2", "3.1", "3.0", "2.7"]
# Promote again when adding 3.4 support
- RUBY_VERSION: ["3.3", "3.2", "3.1", "3.0", "2.7"]
ARCH: [ "amd64", "arm64" ]
stage: package
needs:
Expand Down
4 changes: 2 additions & 2 deletions lib-injection/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -41,9 +41,9 @@ Currently, we support

| Environment| version |
|---|---|
| Ruby | `2.7`, `3.0`, `3.1`, `3.2`|
| Ruby | `2.7`, `3.0`, `3.1`, `3.2`, `3.3`|
| Arch | `amd64`, `arm64` |
| glibc | 2.28+ |
| glibc | 2.17+ |

In order to ship `datadog` and its dependencies as a pre-install package, we need a few tweaks in our build pipeline.

Expand Down
2 changes: 1 addition & 1 deletion lib-injection/host_inject.rb
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ def runtime_supported?
major, minor, = RUBY_VERSION.split('.')
ruby_api_version = "#{major}.#{minor}.0"

supported_ruby_api_versions = ['2.7.0', '3.0.0', '3.1.0', '3.2.0'].freeze
supported_ruby_api_versions = ['2.7.0', '3.0.0', '3.1.0', '3.2.0', '3.3.0'].freeze

RUBY_ENGINE == 'ruby' && supported_ruby_api_versions.any? { |v| ruby_api_version == v }
end
Expand Down

0 comments on commit 36af0b4

Please sign in to comment.