Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update master with 2.7.1 release #4174

Merged
merged 17 commits into from
Nov 29, 2024
Merged

Update master with 2.7.1 release #4174

merged 17 commits into from
Nov 29, 2024

Conversation

TonyCTHsu
Copy link
Contributor

What does this PR do?

Update master with patch release

@TonyCTHsu TonyCTHsu added the dev/internal Other internal work that does not need to be included in the changelog label Nov 28, 2024
@TonyCTHsu TonyCTHsu requested review from a team as code owners November 28, 2024 16:17
@github-actions github-actions bot added profiling Involves Datadog profiling tracing labels Nov 28, 2024
@ivoanjo
Copy link
Member

ivoanjo commented Nov 29, 2024

I've clicked the button to merge master into this branch so the diff is correct (e.g. the diff is really the differences between master and 2.7-stable; otherwise the diff is really weird.

This was done under the assumption we won't do other releases in the 2.7.x series; if we do need to do that, we can force-push the branch back to 94f50fe and resume from there.

Copy link
Member

@ivoanjo ivoanjo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 This LGTM. I suggest holding on merging before we get a clarification about the system-tests.yml changes, but otherwise it's good to go.

.github/workflows/system-tests.yml Show resolved Hide resolved
@datadog-datadog-prod-us1
Copy link
Contributor

datadog-datadog-prod-us1 bot commented Nov 29, 2024

Datadog Report

Branch report: 2.7-stable
Commit report: cb9aedd
Test service: dd-trace-rb

✅ 0 Failed, 22043 Passed, 1459 Skipped, 5m 41.02s Total Time

@codecov-commenter
Copy link

codecov-commenter commented Nov 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.75%. Comparing base (8200cf3) to head (cb9aedd).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4174      +/-   ##
==========================================
- Coverage   97.77%   97.75%   -0.02%     
==========================================
  Files        1351     1351              
  Lines       81733    81734       +1     
  Branches     4147     4147              
==========================================
- Hits        79911    79900      -11     
- Misses       1822     1834      +12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pr-commenter
Copy link

pr-commenter bot commented Nov 29, 2024

Benchmarks

Benchmark execution time: 2024-11-29 13:08:15

Comparing candidate commit cb9aedd in PR branch 2.7-stable with baseline commit 8200cf3 in branch master.

Found 0 performance improvements and 1 performance regressions! Performance is the same for 30 metrics, 2 unstable metrics.

scenario:profiler - sample timeline=false

  • 🟥 throughput [-0.630op/s; -0.613op/s] or [-9.528%; -9.272%]

@ivoanjo ivoanjo requested review from a team and removed request for a team November 29, 2024 11:00
Fix handling of non integer response status code in AppSec
@y9v y9v requested a review from a team as a code owner November 29, 2024 12:23
@github-actions github-actions bot added the appsec Application Security monitoring product label Nov 29, 2024
Copy link
Member

@ivoanjo ivoanjo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

@ivoanjo
Copy link
Member

ivoanjo commented Nov 29, 2024

Hopefully CI will be clear now and we can merge this!

@ivoanjo ivoanjo merged commit 28675b6 into master Nov 29, 2024
314 checks passed
@github-actions github-actions bot added this to the 2.8.0 milestone Nov 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
appsec Application Security monitoring product dev/internal Other internal work that does not need to be included in the changelog profiling Involves Datadog profiling tracing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants