Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to Disable APM via the Helm Chart #1599

Open
hamishdh opened this issue Nov 5, 2024 · 1 comment
Open

Unable to Disable APM via the Helm Chart #1599

hamishdh opened this issue Nov 5, 2024 · 1 comment
Labels
chart/datadog This issue or pull request is related to the datadog chart

Comments

@hamishdh
Copy link

hamishdh commented Nov 5, 2024

Describe what happened:

I am unable to disable APM trace collection via the Helm chart. I had initially enabled it by setting the below config:

    datadog:
      apm:
        socketEnabled: true
        portEnabled: true

To disable it, I have tried setting the below values:

    datadog:
      apm:
        socketEnabled: false
        portEnabled: false

The Helm release deploys, however APM traces are still being collected. A 'trace-agent' container is still being created in the DataDog DaemonSet and it has the environment variable: DD_APM_ENABLED=true.

The 'agent' / 'process-agent' containers correctly have the environment variable DD_APM_ENABLED=false.

Also interestingly, I enabled debug logging by setting datadog.logLevel: 'DEBUG" and I observer that the DD_LOG_LEVEL environment variable was correctly updated on the 'agent' and 'process-agent' containers, however not the 'trace-agent' container.

Describe what you expected:

  • 'trace-agent' container to be removed from the DaemonSet

Steps to reproduce the issue:

  1. Enable APM by setting datadog.apm.socketEnabled: true & datadog.apm.portEnabled: true.
  2. Attempt to disable APM by setting datadog.apm.socketEnabled: false&datadog.apm.portEnabled: false`.

Additional environment details (Operating System, Cloud provider, etc):

  • Using 3.7.6 version of Helm Chart
  • Running in AWS EKS
  • Using FluxCD for Helm deployments
@celenechang
Copy link
Contributor

Hi @hamishdh , thanks for opening the issue. I was unable to reproduce what you experienced; do you happen to have anything else set in your values.yaml file under datadog.apm?

(From Git history, I don't think Helm chart version would affect this, but it may be worth trying an updated version.)

In my test values.yaml file, toggling apm.socketEnabled was sufficient to add/remove the trace agent to/from the pod:

datadog:
  apiKey: [redacted]
  appKey: [redacted]

  apm:
    socketEnabled: false # true

On the latest chart version, the logic deciding whether the trace agent should be included is here. The only element that is true by default is datadog.apm.socketEnabled.

I hope that helps - please let me know if I missed anything.

@celenechang celenechang added the chart/datadog This issue or pull request is related to the datadog chart label Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chart/datadog This issue or pull request is related to the datadog chart
Projects
None yet
Development

No branches or pull requests

2 participants