Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify rules based on a set of possible addresses #71

Open
cataphract opened this issue Apr 27, 2022 · 1 comment
Open

Simplify rules based on a set of possible addresses #71

cataphract opened this issue Apr 27, 2022 · 1 comment
Labels
enhancement New feature or request

Comments

@cataphract
Copy link
Contributor

The WAF runs on logs processing with only a few addresses ever pushed. It would likely result in a substantial performance improvement if the rules could be stripped of all addresses that will never be pushed, and rules with no addresses left removed.

This could be implemented as a new option when rules are loaded, or, perhaps a worse option, as a tool to preprocess the rules file.

@cataphract cataphract added the enhancement New feature or request label Apr 27, 2022
@Anilm3
Copy link
Collaborator

Anilm3 commented May 27, 2022

Removing rules based on the available addresses would make sense, as a feature within the WAF, if the set of available addresses changes frequently enough that having a limited ruleset becomes an operational burden. Otherwise, it's simple enough to preprocess a ruleset and eliminate irrelevant rules before passing them to the WAF.

In any case, in the future I plan to explore an alternative way of processing rules which will be based on the available addresses, so perhaps the performance impact of irrelevant rules will be negligible then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants