Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make protobuf an optional requirement #62

Merged
merged 4 commits into from
Mar 29, 2024
Merged

make protobuf an optional requirement #62

merged 4 commits into from
Mar 29, 2024

Conversation

emmettbutler
Copy link
Collaborator

What does this PR do?

Makes protobuf not install by default, instead putting it under the "serialization" install feature

Motivation

ddtracepy can't depend on protobuf anymore. see DataDog/dd-trace-py#8797 for details.

Kyle-Verhoog
Kyle-Verhoog reviewed Mar 29, 2024
View reviewed changes
Copy link
Member

@Kyle-Verhoog Kyle-Verhoog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should have a release note for this change. Otherwise LGTM. We should bump the major for this too as it's a breaking change (despite the wording in the README hinting that the dependency is optional already).

@emmettbutler emmettbutler mentioned this pull request Mar 29, 2024
Closed
18 tasks
@emmettbutler emmettbutler merged commit 72f179a into master Mar 29, 2024
16 of 17 checks passed
@emmettbutler emmettbutler deleted the emmett.butler/pbopt branch March 29, 2024 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kyle-Verhoog Kyle-Verhoog Kyle-Verhoog approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emmettbutler @Kyle-Verhoog