Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add asdf as way to install #495

Merged

Conversation

vthiery
Copy link
Contributor

@vthiery vthiery commented Mar 8, 2024

What does this PR do?

Document how to install stratus-red-team using asdf.
I have also slightly changed how installation methods are listed for clarity.

Motivation

Using asdf and the plugin I wrote for stratus-red-team is a convenient way to use / test different versions of stratus-red-team.

Checklist

NA

@christophetd
Copy link
Contributor

Thanks for the contribution! I'm happy to add asdf support, but I'd like to have the plugin repo as part of the same repo. Is there a way to add it e.g. in a subfolder?

@vthiery
Copy link
Contributor Author

vthiery commented Mar 8, 2024

Thanks for the contribution! I'm happy to add asdf support, but I'd like to have the plugin repo as part of the same repo. Is there a way to add it e.g. in a subfolder?

I believe that the "right" way to maintain asdf plugins is the way it is now: separate from the actual tool.
I have raised a PR to add the plugin to the plugins directory: asdf-vm/asdf-plugins#971

If we want more assurance around the maintenance of the plugin, I am happy to transfer ownership to the asdf--community .

What do you think?

@christophetd
Copy link
Contributor

christophetd commented Mar 8, 2024

Transfering to asdf-community would be optimal, thank you

@vthiery
Copy link
Contributor Author

vthiery commented Mar 8, 2024

Transfering to asdf-community would be optimal, thank you

Let me proceed with the transfer then and I will update this PR accordingly.

@christophetd
Copy link
Contributor

Hi @vthiery, still eager to merge this, let me know when the transfer happens! Thanks

@christophetd christophetd force-pushed the docs/include-asdf-as-way-to-install branch from 4128cf8 to dc11d62 Compare April 4, 2024 10:26
@vthiery
Copy link
Contributor Author

vthiery commented Apr 8, 2024

Hi @christophetd, I'm still waiting on the asdf-community to initiate the transfer asdf-community/infrastructure#149

@christophetd
Copy link
Contributor

Thanks! I left a comment in the linked PR as well

@vthiery
Copy link
Contributor Author

vthiery commented Apr 29, 2024

@christophetd the repository has been transferred.

@christophetd
Copy link
Contributor

Thanks @vthiery ! Do you have any thoughs on what we should do when a new version of Stratus Red team gets released? I.s. how to bump the asdf version, and how we could automate this?

@vthiery
Copy link
Contributor Author

vthiery commented Apr 29, 2024

@christophetd there is nothing to do from your side as the asdf plugin will be able to retrieve all the releases, including the "latest" as soon as it's released.

As a user, one can simply use asdf install stratus-red-team latest to get the latest release.
If one want a specific version, asdf install stratus-red-team 2.15.0 would be the way to go.
Users may also do asdf list all stratus-red-team to list all the versions available.

Bonus tip: one can shorten the plugin name when adding it to avoid repeating "stratus-red-team". E.g. asdf plugin add stratus https://github.com/asdf-community/asdf-stratus-red-team.git and then asdf list all stratus.

@christophetd
Copy link
Contributor

Amazing! Thanks for all the work around this

@christophetd christophetd enabled auto-merge (squash) April 29, 2024 11:14
@christophetd christophetd merged commit b62b180 into DataDog:main May 1, 2024
5 checks passed
@vthiery vthiery deleted the docs/include-asdf-as-way-to-install branch May 1, 2024 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants