Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[datadog_synthetics_test] Add persistCookies option #2058

Merged
merged 6 commits into from
Aug 18, 2023

Conversation

luissmg
Copy link
Contributor

@luissmg luissmg commented Aug 14, 2023

Add configuration to API test request to persist cookies across redirects.

SYNTH-10516

@luissmg luissmg requested review from a team as code owners August 14, 2023 15:57
@luissmg luissmg changed the title [Synthetics][SYNTH-10516] Add persistCookies option synthetics test request [Synthetics] Add persistCookies option synthetics test request Aug 15, 2023
@luissmg luissmg requested a review from a team as a code owner August 16, 2023 10:16
@therve therve changed the title [Synthetics] Add persistCookies option synthetics test request [datadog_synthetics_test] Add persistCookies option Aug 16, 2023
buraizu
buraizu previously approved these changes Aug 16, 2023
Copy link
Contributor

@buraizu buraizu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, approving with just a minor update for consistency

docs/resources/synthetics_test.md Outdated Show resolved Hide resolved
docs/resources/synthetics_test.md Outdated Show resolved Hide resolved
therve
therve previously approved these changes Aug 17, 2023
buraizu
buraizu previously approved these changes Aug 17, 2023
@luissmg luissmg dismissed stale reviews from buraizu and therve via ee5c7f4 August 18, 2023 08:26
@luissmg luissmg merged commit 5f73c31 into master Aug 18, 2023
8 checks passed
@luissmg luissmg deleted the luis.gouveia/SYNTH-10516-persist-cookies-api-test branch August 18, 2023 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants