Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Optimization] move web some url to constants #3197

Merged
merged 5 commits into from
Feb 28, 2024

Conversation

Zzm0809
Copy link
Contributor

@Zzm0809 Zzm0809 commented Feb 28, 2024

Purpose of the pull request

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

@Zzm0809 Zzm0809 added the Optimization Optimization function label Feb 28, 2024
Copy link
Contributor

@gaoyan1998 gaoyan1998 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gaoyan1998 gaoyan1998 merged commit 9f000ed into DataLinkDC:dev Feb 28, 2024
13 checks passed
@Zzm0809 Zzm0809 deleted the move-web-url-to-constants branch March 4, 2024 04:21
gaoyan1998 pushed a commit to gaoyan1998/dinky that referenced this pull request Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Optimization Optimization function
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants