Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] [Flink SQL] Added ADD FILE syntax not only submits JAR to Java ClassPath #3205

Merged
merged 5 commits into from
Mar 1, 2024

Conversation

zackyoungh
Copy link
Contributor

@zackyoungh zackyoungh commented Feb 29, 2024

Purpose of the pull request

Brief change log

image

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

@zackyoungh zackyoungh added the New Feature New feature label Feb 29, 2024
@zackyoungh zackyoungh added this to the 1.0.0 milestone Feb 29, 2024
@zackyoungh zackyoungh self-assigned this Feb 29, 2024
@Zzm0809
Copy link
Contributor

Zzm0809 commented Feb 29, 2024

add doc

add this statement to document table

@@ -16,7 +16,7 @@ spring:
# If you use pgsql database, please configure pgsql database connection information in application-pgsql.yml
# If you use the h2 database, please configure the h2 database connection information in application-h2.yml,
# note: the h2 database is only for experience use, and the related data that has been created cannot be migrated, please use it with caution
active: ${DB_ACTIVE:h2} #[h2,mysql,pgsql]
active: ${DB_ACTIVE:mysql} #[h2,mysql,pgsql]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rollback

Copy link
Contributor

@aiwenmo aiwenmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zackyoungh zackyoungh merged commit 93c43d1 into DataLinkDC:dev Mar 1, 2024
13 checks passed
gaoyan1998 pushed a commit to gaoyan1998/dinky that referenced this pull request Mar 19, 2024
@zackyoungh zackyoungh deleted the add_file branch September 25, 2024 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
New Feature New feature
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[Feature][Flink SQL] Added ADD FILE syntax not only submits JAR to Java ClassPath
3 participants