Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Registering User backed error checking #25

Open
Maker-Mark opened this issue Aug 11, 2019 · 11 comments
Open

Registering User backed error checking #25

Maker-Mark opened this issue Aug 11, 2019 · 11 comments
Assignees
Labels
help wanted Extra attention is needed

Comments

@Maker-Mark
Copy link
Collaborator

Maker-Mark commented Aug 11, 2019

  • Make sure the API response is parsed for an error before assuming logged in.
  • QA: Please test registering a new user, and post any issues below.
@Maker-Mark Maker-Mark added the help wanted Extra attention is needed label Aug 11, 2019
@Maker-Mark Maker-Mark changed the title Resister Backend error checking Registering User backed error checking Aug 11, 2019
@LoadingUser3
Copy link
Contributor

Whenever I register a user, the following occurs:

image

This happens with a variety of different credentials.

I am registering directly from the site.

Some very minor issues I noticed while performing tests:

  • The user does not know what the requirements are for the Username, Email or Password fields until after they make a mistake. This can confuse users until they either click Register or accidentally fulfill the requirements.

  • Every field gets wiped when it fails to register, including uploaded images. This can discourage users from wanting to register if they have to re-enter all the information again.

These aren't urgent issues, but I thought I should bring these up.

I have also made a document of tests that I have performed in the page under master/Quality Control/Written Reports of Tests/Registering User Tests. This will be regularly updated as we perform more tests.

Hopefully this was helpful!

@derickfan
Copy link
Contributor

Hey, is there any chance you haven't updated your project? Also currently uploading an image for your user profile is not supported right now. I'll also look into saving the fields when failling to register. Thanks for the feedback!

@LoadingUser3
Copy link
Contributor

My most recent update was around 2pm, will update again and check. Thanks!

@mary060196
Copy link
Contributor

Please note that an optional argument is added to the render_template that fires the message 'Username already in use!' If it was not removed by now from the render_template, you could do so.

The optional argument's name is errUsernameInUse, and it should be passed to the function only if some user who tries to register is asking to use a username that is already in the database (since the username must be unique).

@Maker-Mark
Copy link
Collaborator Author

@mary060196
Could you set up a variable for both {{if login_err}} then display for every error display{{ given_error}}?
That way we can just send back the error to display in a list, and if it's more than one just iterate though it and display the errors

@mary060196
Copy link
Contributor

A question: do you want just one ifstatement, and two errors to be displayed for that statement? What are the corresponding names for the two error variables that you would like to be added?
Thanks!

@LoadingUser3
Copy link
Contributor

Results: Successfully registered as a user!

Tried with various credentials.

Screenshots:
image

image

image

Tasks the user can do:
• View port indexes
• Enter each port
• Subscribe to port (only through port index, not through trending ports)
• Visit the Our Team links
• Visit the Contact Us links
• Visit the Terms and Conditions link
• Sign out and sign back in (the credentials are retained).

Tasks the user cannot do:
• Go to User Profile
• Go to Dashboard
• Go to Account Settings
• Create post (At least, I cannot select the communities even after subscribing to them).

(I am assuming most of these aren't implemented yet but just letting you guys know)

I apologize for the delay on this information. Will add more members for a faster response.

@abrahym-sharfeldden
Copy link
Contributor

Suggestion: Add error handling for new users who try to use a username already in use.

I get redirected to this page when I attempt to register with a username that is already in use:

Decoder Error

@mary060196
Copy link
Contributor

Hello, @abrahym-sharfeldden !
I am about to add an error handing argument to the template, which will be caught by the Back End team later, so that a user who enters an existing username, will be redirected again to the registration page and see the message: "Username in use!" or the like. Please keep on watching for the issue to be resolved.
Great thanks!

@mary060196
Copy link
Contributor

@Maker-Mark !
Two arguments for error detection in the Register template were added! Now you can choose what error to display at each time, based on the user's input.
The template checks for two arguments with the names: username_error and email_error, which is exactly as you suggested today.
Lastly, I modified the test.py such that it passes both arguments to the render_template (for visualization).
Thank you very much for your diligence!

@mary060196
Copy link
Contributor

@abrahym-sharfeldden , the changes within the templates have been made; now the Back End team will connect to the template and be able to monitor which errors to show!
Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

10 participants