Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Hashdiff to be case sensitive seperately from hash keys #247

Open
barrystr opened this issue Sep 3, 2024 · 2 comments
Open

Allow Hashdiff to be case sensitive seperately from hash keys #247

barrystr opened this issue Sep 3, 2024 · 2 comments
Assignees
Labels
feature This is is requesting a new feature

Comments

@barrystr
Copy link

barrystr commented Sep 3, 2024

Is your feature request related to a problem? Please describe.
We have a requirement to make hashdiff results case sensitive while keeping the hash keys as case insensitive

Describe the solution you'd like
A clear and concise description of what you want to happen.

Describe alternatives you've considered
I have added a new variable hashdiff_content_casing that can be set to upper or disabled in the same way as the hash_content_casing. Changes were required to standard_column_wrapper to accept the is-hashdiff parameter. hash amd null_expression were changed to pass the parameter.

Additional context
We considered making both the keys and hashdiff case sensitive but we did still need the keys to remain as they were.

AB#5614

@barrystr barrystr added the feature This is is requesting a new feature label Sep 3, 2024
@barrystr barrystr changed the title [FEATURE] Allow Hashdiff to be case sensitive seperately from hash keys Sep 3, 2024
@barrystr
Copy link
Author

barrystr commented Sep 3, 2024

I've applied the changes I made to this codespace - https://expert-space-meme-9g9wxvrwwgp2x9g4.github.dev/

@DVAlexHiggs
Copy link
Member

Hi! Thanks for this 😄 This has been requested for a while but hasn't been implemented yet due to other priorities - we'll make sure this goes into an upcoming release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature This is is requesting a new feature
Projects
None yet
Development

No branches or pull requests

2 participants