-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Case of string values. #12
Comments
Honestly, why are you setting it to strings in the first place? the |
As I said, it's a recommended, I'm using this element in 2 different scenarios, in both this check is "good to have". Anyway even if you don't want to parse. Check with Number.isInteger in order not to produce errors in javascript. Probably I'll not to fork your repository in order to add additional configuration and bug fixes. I'll try to make some pull request for your judgement. |
@0rion7st Well, there are a million other ways developers could give incorrect input as well, so I am not going to check every attribute whether it's valid as that's a waste of runtime. BUT there is a big bug caused by the lack of a |
In case when value is {"red":"255","green":"255","blue":"255","alpha":"0.5"}
Properties are not Numbers function: _setValueAsHexFromValue works not correct.
Recommended fix:
paper-color-input.html:206
var h = parseInt(value[c]).toString(16);
The text was updated successfully, but these errors were encountered: