Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support hierarchical .markdownlintignore files #2

Closed
borekb opened this issue Aug 13, 2020 · 3 comments
Closed

Support hierarchical .markdownlintignore files #2

borekb opened this issue Aug 13, 2020 · 3 comments
Labels
enhancement New feature or request

Comments

@borekb
Copy link

borekb commented Aug 13, 2020

This cli2 supports hierarchical config files (.markdownlint.json) but not ignore files (.markdownlintignore). This feels inconsistent, for example, I can customize lint rules per subfolder but can't customize ignore rules in the same way.

Why this is a problem in larger repos is described here: igorshubovych/markdownlint-cli#45 (comment).

@DavidAnson
Copy link
Owner

This is currently by explicit design - there's more discussion in #2. Specifically, all the globs need to be available before globbing starts for best performance. A single .markdownlintignore file in the current directory is easy to pre-read - but allowing multiple of them throughout the tree risks performance problems.

Aside: I may introduce "ignore" globs in .markdownlint-cli2.json for convenience, but those will explicitly be called out as a performance anti-pattern.

@DavidAnson DavidAnson added the question Further information is requested label Aug 14, 2020
@borekb
Copy link
Author

borekb commented Aug 14, 2020

Thanks, the issue link should be #1 (this comment specifically) I believe.

@DavidAnson
Copy link
Owner

Yes, thanks for the correction! And there is an update there that's relevant here that may provide a nice resolution for both issues: #1 (comment)

@DavidAnson DavidAnson added enhancement New feature or request and removed question Further information is requested labels Aug 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants