Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optional(?) Strict Integrity Checks #18

Open
DavidBuchanan314 opened this issue Dec 4, 2024 · 0 comments
Open

Optional(?) Strict Integrity Checks #18

DavidBuchanan314 opened this issue Dec 4, 2024 · 0 comments

Comments

@DavidBuchanan314
Copy link
Owner

DavidBuchanan314 commented Dec 4, 2024

SQLite doesn't even do checksumming by default. If data in our db got silently corrupted, we might end up emitting invalid diffs, etc. In these scenarios, it would be much better to panic.

Treating the db as an "untrusted" block store and checking the hash of everything we load could get expensive, but, it would essentially eliminate this.

It probably won't hurt perf significantly, and it'd be great for peace-of-mind.

I'll run some benchmarks before I decide whether it's optional/default/mandatory

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant