We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"Prepare" is a read-only phase, generating a description of the required changes to be made to the repo.
"Apply" actually persists those changes to the db (making sure no other commits have been applied in the meantime!)
Currently both are rolled into one - the giant apply_writes function in repo_ops.py (nb: the verb "apply" is overloaded here - think of a better one?)
apply_writes
repo_ops.py
There are several benefits to this change:
The text was updated successfully, but these errors were encountered:
Should probably separate out the core commit logic from the firehose message generation logic, too
Sorry, something went wrong.
re: verbs - "persist" seems like a good word for the second phase
No branches or pull requests
"Prepare" is a read-only phase, generating a description of the required changes to be made to the repo.
"Apply" actually persists those changes to the db (making sure no other commits have been applied in the meantime!)
Currently both are rolled into one - the giant
apply_writes
function inrepo_ops.py
(nb: the verb "apply" is overloaded here - think of a better one?)There are several benefits to this change:
The text was updated successfully, but these errors were encountered: