adapt tsconfig to angular v18

eanble no-explicit-any rule again and fix errors

client/app/services/user.service.ts

@@ -13,8 +13,8 @@ export class UserService {
     return this.http.post<User>('/api/user', user);
   }
 
-  login(credentials: { email: string; password: string }): Observable<any> {
-    return this.http.post('/api/login', credentials);
+  login(credentials: { email: string; password: string }): Observable<{ token: string }> {
+    return this.http.post<{ token: string }>('/api/login', credentials);
   }
 
   getUsers(): Observable<User[]> {
@@ -33,11 +33,11 @@ export class UserService {
     return this.http.get<User>(`/api/user/${user._id}`);
   }
 
-  editUser(user: User): Observable<any> {
+  editUser(user: User): Observable<string> {
     return this.http.put(`/api/user/${user._id}`, user, { responseType: 'text' });
   }
 
-  deleteUser(user: User): Observable<any> {
+  deleteUser(user: User): Observable<string> {
     return this.http.delete(`/api/user/${user._id}`, { responseType: 'text' });
   }
 

eslint.config.js

@@ -30,8 +30,6 @@ module.exports = tseslint.config(
           style: "kebab-case",
         },
       ],
-      "@typescript-eslint/no-explicit-any": "off",
-      "no-underscore-dangle": "off",
       "arrow-spacing": "error",
       "comma-spacing": "error",
       "indent": ["error", 2],

server/controllers/base.ts

@@ -2,15 +2,16 @@ import { Request, Response } from 'express';
 
 abstract class BaseCtrl {
 
+  // eslint-disable-next-line @typescript-eslint/no-explicit-any
   abstract model: any;
 
   // Get all
   getAll = async (req: Request, res: Response) => {
     try {
       const docs = await this.model.find({});
       return res.status(200).json(docs);
-    } catch (err: any) {
-      return res.status(400).json({ error: err.message });
+    } catch (err) {
+      return res.status(400).json({ error: (err as Error).message });
     }
   };
 
@@ -19,8 +20,8 @@ abstract class BaseCtrl {
     try {
       const count = await this.model.countDocuments();
       return res.status(200).json(count);
-    } catch (err: any) {
-      return res.status(400).json({ error: err.message });
+    } catch (err) {
+      return res.status(400).json({ error: (err as Error).message });
     }
   };
 
@@ -29,8 +30,8 @@ abstract class BaseCtrl {
     try {
       const obj = await new this.model(req.body).save();
       return res.status(201).json(obj);
-    } catch (err: any) {
-      return res.status(400).json({ error: err.message });
+    } catch (err) {
+      return res.status(400).json({ error: (err as Error).message });
     }
   };
 
@@ -39,8 +40,8 @@ abstract class BaseCtrl {
     try {
       const obj = await this.model.findOne({ _id: req.params.id });
       return res.status(200).json(obj);
-    } catch (err: any) {
-      return res.status(500).json({ error: err.message });
+    } catch (err) {
+      return res.status(500).json({ error: (err as Error).message });
     }
   };
 
@@ -49,8 +50,8 @@ abstract class BaseCtrl {
     try {
       await this.model.findOneAndUpdate({ _id: req.params.id }, req.body);
       return res.sendStatus(200);
-    } catch (err: any) {
-      return res.status(400).json({ error: err.message });
+    } catch (err) {
+      return res.status(400).json({ error: (err as Error).message });
     }
   };
 
@@ -59,8 +60,8 @@ abstract class BaseCtrl {
     try {
       await this.model.findOneAndDelete({ _id: req.params.id });
       return res.sendStatus(200);
-    } catch (err: any) {
-      return res.status(400).json({ error: err.message });
+    } catch (err) {
+      return res.status(400).json({ error: (err as Error).message });
     }
   };
 
@@ -69,8 +70,8 @@ abstract class BaseCtrl {
     try {
       await this.model.deleteMany();
       return res.sendStatus(200);
-    } catch (err: any) {
-      return res.status(400).json({ error: err.message });
+    } catch (err) {
+      return res.status(400).json({ error: (err as Error).message });
     }
   };
 }

server/controllers/user.ts

@@ -15,15 +15,15 @@ class UserCtrl extends BaseCtrl {
       if (!user) {
         return res.sendStatus(403);
       }
-      return user.comparePassword(req.body.password, (error: any, isMatch: boolean) => {
+      return user.comparePassword(req.body.password, (error, isMatch: boolean) => {
         if (error || !isMatch) {
           return res.sendStatus(403);
         }
         const token = sign({ user }, secret, { expiresIn: '24h' });
         return res.status(200).json({ token });
       });
-    } catch (err: any) {
-      return res.status(400).json({ error: err.message });
+    } catch (err) {
+      return res.status(400).json({ error: (err as Error).message });
     }
   };
 

server/models/cat.ts

@@ -14,4 +14,5 @@ const catSchema = new Schema<ICat>({
 
 const Cat = model<ICat>('Cat', catSchema);
 
+export type { ICat };
 export default Cat;

server/models/user.ts

@@ -7,6 +7,7 @@ interface IUser {
   password: string;
   role: string;
   isModified(password: string): boolean;
+  // eslint-disable-next-line @typescript-eslint/no-explicit-any
   comparePassword(password: string, callback: (err: any, isMatch: boolean) => void): boolean;
 }
 
@@ -32,6 +33,7 @@ userSchema.pre<IUser>('save', function(next): void {
   });
 });
 
+// eslint-disable-next-line @typescript-eslint/no-explicit-any
 userSchema.methods.comparePassword = function(candidatePassword: string, callback: any): void {
   compare(candidatePassword, this.password, (err, isMatch) => {
     if (err) { return callback(err); }

server/tsconfig.json

@@ -3,7 +3,7 @@
   "compilerOptions": {
     "outDir": "../dist/server",
     "baseUrl": "",
-    "module": "commonjs",
+    "types": ["node", "jest"],
     "skipLibCheck": true // Added due to jest and jasmine errors
   }
 }

tsconfig.json

@@ -1,24 +1,24 @@
-/* To learn more about this file see: https://angular.io/config/tsconfig. */
+/* To learn more about Typescript configuration file: https://www.typescriptlang.org/docs/handbook/tsconfig-json.html. */
+/* To learn more about Angular compiler options: https://angular.dev/reference/configs/angular-compiler-options. */
 {
   "compileOnSave": false,
   "compilerOptions": {
     "baseUrl": "./",
     "outDir": "./dist/out-tsc",
-    "forceConsistentCasingInFileNames": true,
-    "esModuleInterop": true,
     "strict": true,
     "noImplicitOverride": true,
-    "noPropertyAccessFromIndexSignature": false, // Default is true
+    "noPropertyAccessFromIndexSignature": false,
     "noImplicitReturns": true,
     "noFallthroughCasesInSwitch": true,
+    "isolatedModules": true,
+    "esModuleInterop": true,
     "sourceMap": true,
     "declaration": false,
     "experimentalDecorators": true,
-    "moduleResolution": "node",
+    "moduleResolution": "bundler",
     "importHelpers": true,
     "target": "ES2022",
     "module": "ES2022",
-    "useDefineForClassFields": false,
     "lib": [
       "ES2022",
       "dom"
@@ -30,4 +30,4 @@
     "strictInputAccessModifiers": true,
     "strictTemplates": true
   }
-}
+}