Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Order button updates #72

Closed
8 of 10 tasks
EngineerCharlie opened this issue Aug 15, 2023 · 1 comment
Closed
8 of 10 tasks

Order button updates #72

EngineerCharlie opened this issue Aug 15, 2023 · 1 comment
Assignees
Labels
bug Something isn't working design enhancement New feature or request

Comments

@EngineerCharlie
Copy link
Contributor

EngineerCharlie commented Aug 15, 2023

I'm just opening this issue to consolidate all the feature adjustments needed for the order button. This consolidates previous issues/code todos.

New features:

Feature adjustments/improvements:

  • Change price on a limit order is 5% below or above best buy/sell alert to be less intrusive (eg toast) (Order guardrails to prevent fat fingering #50)
  • Change slippage greater than 5% alert to be less intrusive (eg a toast) (Order guardrails to prevent fat fingering #50)
  • Adjust % button behaviour to put in the requested amount even if there is not liquidity
  • Improve wording and information given in trade "description"
  • Quickly typing in a percentage position size on the "Buy" side sends a call to fetch balances too quickly. Might need debouncing

Other updates:

@EngineerCharlie EngineerCharlie added bug Something isn't working enhancement New feature or request design labels Aug 15, 2023
@EngineerCharlie EngineerCharlie self-assigned this Aug 28, 2023
@EvgeniiaVak EvgeniiaVak moved this from Todo to In Progress in development Aug 29, 2023
@EvgeniiaVak
Copy link
Member

fixed by #117

@github-project-automation github-project-automation bot moved this from In Progress to Done in development Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working design enhancement New feature or request
Projects
Archived in project
Development

No branches or pull requests

3 participants