Can't build 1.9.0 for Fedora

[Vascom]

I can't build deadbeef 1.9.0 for Fedora with this errors:

ddbequalizer.c:110:13: error: variable '_tmp5_' set but not used [-Werror,-Wunused-but-set-variable]
    gdouble _tmp5_ = 0.0;
            ^
ddbequalizer.c:452:18: error: variable '_tmp24__length1' set but not used [-Werror,-Wunused-but-set-variable]
            gint _tmp24__length1;
                 ^
ddbequalizer.c:454:21: error: variable '_tmp26_' set but not used [-Werror,-Wunused-but-set-variable]
            gdouble _tmp26_;
                    ^
ddbequalizer.c:471:22: error: variable '_tmp30__length1' set but not used [-Werror,-Wunused-but-set-variable]
                gint _tmp30__length1;
                     ^
ddbequalizer.c:473:25: error: variable '_tmp32_' set but not used [-Werror,-Wunused-but-set-variable]
                gdouble _tmp32_;
ddbequalizer.c:462:18: error: variable '_tmp27__length1' set but not used [-Werror,-Wunused-but-set-variable]
            gint _tmp27__length1;
                 ^
ddbequalizer.c:426:14: error: variable '_tmp14__length1' set but not used [-Werror,-Wunused-but-set-variable]
        gint _tmp14__length1;
             ^
ddbequalizer.c:432:17: error: variable '_tmp20_' set but not used [-Werror,-Wunused-but-set-variable]
        gdouble _tmp20_;
                ^
ddbequalizer.c:434:14: error: variable '_tmp21__length1' set but not used [-Werror,-Wunused-but-set-variable]
        gint _tmp21__length1;
             ^
ddbequalizer.c:712:10: error: variable '_tmp0__length1' set but not used [-Werror,-Wunused-but-set-variable]
    gint _tmp0__length1;
ddbequalizer.c:715:13: error: variable '_tmp3_' set but not used [-Werror,-Wunused-but-set-variable]
    gdouble _tmp3_;
            ^
ddbequalizer.c:729:10: error: variable '_tmp0__length1' set but not used [-Werror,-Wunused-but-set-variable]
    gint _tmp0__length1;
         ^
ddbequalizer.c:775:20: error: variable 'self' set but not used [-Werror,-Wunused-but-set-variable]
    DdbEqualizer * self;

ddbtabstrip.c:1259:15: error: variable 'ev_y' set but not used [-Werror,-Wunused-but-set-variable]
    int ev_x, ev_y;

ddbseekbar.c:82:15: error: variable 'self' set but not used [-Werror,-Wunused-but-set-variable]
        DdbSeekbar * self;
                     ^
ddbseekbar.c:147:15: error: variable 'self' set but not used [-Werror,-Wunused-but-set-variable]
        DdbSeekbar * self;
                     ^
ddbseekbar.c:191:15: error: variable 'self' set but not used [-Werror,-Wunused-but-set-variable]
        DdbSeekbar * self;

Deadbeef version: 1.9.0
OS: Fedora

[Oleksiy-Yakovenko]

Seems like some environment variable forces additional -Werror flags, in addition to those specified in deadbeef build scripts.
You should either find and disable this behavior, or pass CFLAGS="-Wnoerror" when compiling deadbeef.

[Vascom]

Thanks. I added -Wno-unused-but-set-variable flag.
But may be remove this variables from code or use them?

[Oleksiy-Yakovenko]

I do cleanup the code and increase warning level on a regular basis -- in fact, there was a lot of work done in this direction throughout the 1.9.0 development cycle.
However, the number of warnings is infinite, and there are other priorities.
I can't promise that I'll fix this any time soon, since there's no real problem there - this stuff literally gets optimized out by the compiler anyway, and all of it is old autogenerated code.

[Vascom]

OK.
Packages for Fedora built https://koji.rpmfusion.org/koji/taskinfo?taskID=544050

[Oleksiy-Yakovenko]

@Vascom this has been resolved on master branch, and should not be necessary when building the next release.

[Vascom]

Thanks.