EF-83-add _id product swagger in cart (#6)

Deco-Team · Jan 25, 2024 · 41dde80 · 41dde80
1 parent 87d7b4e
commit 41dde80
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 1 deletion.
diff --git a/src/cart/services/cart.service.ts b/src/cart/services/cart.service.ts
@@ -9,6 +9,11 @@ export class CartService {
 
   public async addToCart(addToCartDto: AddToCartDto) {
     const { customerId, product, quantity } = addToCartDto
+
+    // TODO: Check exists productId, implement after product module done
+
+    // TODO: Check inventory quantity <= product.quantity
+
     const cart = await this.cartRepository.findOne({
       conditions: {
         customerId

diff --git a/src/common/decorators/pagination.decorator.ts b/src/common/decorators/pagination.decorator.ts
@@ -16,7 +16,10 @@ export const handlePagination: (request: any) => PaginationParams = (request) =>
     sort: request.query.sort
   }
   paginationParams.page = Number(paginationParams.page) > 0 ? Number(paginationParams.page) : 1
-  paginationParams.limit = Number(paginationParams.limit) > 0 ? Number(paginationParams.limit) : DEFAULT_LIMIT
+  paginationParams.limit =
+    Number(paginationParams.limit) > 0 && Number(paginationParams.limit) < 100
+      ? Number(paginationParams.limit)
+      : DEFAULT_LIMIT
   if (_.isEmpty(paginationParams.sort)) {
     paginationParams.sort = {
       createdAt: -1

diff --git a/src/product/schemas/product.schema.ts b/src/product/schemas/product.schema.ts
@@ -63,6 +63,7 @@ export class Product {
     this._id = id
   }
 
+  @ApiProperty()
   @Transform(({ value }) => value?.toString())
   _id: string