Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

method update_arguments_if_invalid_input in models\dsheetpiling\internal\SheetPileElement incorrectly raising warnings #200

Closed
RutgerTAUW opened this issue Aug 30, 2024 · 0 comments · Fixed by #201
Assignees

Comments

@RutgerTAUW
Copy link

The method update_arguments_if_invalid_input checks if the values kmod and gamma_m are correctly given by the user. A check is performed to see if the given kmod value is equal to the value it should be by using a dictionary with material IntEnum and corresponding kmod values. In this check however, the user inputed kmod value is compared to the value it should be by using an if not statement. This statement checks if the memory location of both values is the same and does not check if the values are equal. I believe an != statement should be used instead. The same holds for the check of gamma_m_value.

As an example I created a DSheetPiling Model and inputted a kmod value of 1.0. Upon debugging I found that the inputted kmod value was 1.0 and the value corresponding to the sheetpilingelementmaterialtype.value was also equal to 1.0 but still a warning was raised.

@zantDelta zantDelta self-assigned this Sep 2, 2024
@zantDelta zantDelta linked a pull request Sep 3, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants