Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Writing a DIMR model fails (or takes a very long time) when the number of laterals is large #722

Open
RuudHurkmans opened this issue Dec 17, 2024 · 1 comment
Labels
type: enhancement Improvements to existing functionality

Comments

@RuudHurkmans
Copy link
Collaborator

Describe the bug
When a large set of laterals is added to an ExtModel, DIMR.save() iterates over the laterals, writing the entire .BC file for every lateral.

testdata_laterals.zip

To Reproduce

  • Run the attached script, which reads data from the also attached GPKG. The Hydrolib is needed.
  • it builds a dflowfm-model from branches and laterals.
  • The script gets stuck on the 'dimr.save()' line because it writes the .bc file over and over again.

A workaround is to add only the first lateral to the ExtModel, and then write the other laterals afterwards to the existing .ext-file.

Expected behavior
I would expect dimr to write the .ext and .bc file once.

Version info (please complete the following information):

  • OS: Windows 11
  • Hydrolib 0.3.1, Hydrolib-core 0.8.0

Additional context
Add any other context about the problem here.

@arthurvd
Copy link
Member

Thanks Ruud, clear explanation, we'll try and look into it.

@arthurvd arthurvd added the type: enhancement Improvements to existing functionality label Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement Improvements to existing functionality
Projects
Status: To do
Development

No branches or pull requests

2 participants