Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debug RWS-HWS Model #78

Open
12 of 18 tasks
DanielTollenaar opened this issue Apr 15, 2024 · 1 comment
Open
12 of 18 tasks

Debug RWS-HWS Model #78

DanielTollenaar opened this issue Apr 15, 2024 · 1 comment
Assignees
Labels
RWS-HWS Issues in RWS-HWS model

Comments

@DanielTollenaar
Copy link
Collaborator

DanielTollenaar commented Apr 15, 2024

  • Fix Errors:

    • Sluizen Panheel, target-level Kanaal Wessem-Nederweert = 28.65
    • Noordervaart; reverse flow-direction
    • Fix target of Sluis Panheel (kanaal Wessem-Nederweert, not Meuse)
  • To Outlet:

    • Sluis 6 @ Zuid-Willemsvaart (min_level = 15, capacity = 18 m3/s (factsheet operational water management))
    • Sluis 1 @ Wilhelminakanaal (min_level = 15 (has to be 5.15 after including Sluis IV!), capacity = 40 m3/s (factsheet operationeel water management))
    • Sluis Empel @ Máximakanaal (min_level = 2), capacity = 18 m3/s (factsheet operational water management))
    • Sluis Eefde @ Twentekanaal (min_level = 10), capacity 30 m3/s (schatting op basis factsheet owm)
  • Fix errors RWS-HWS model inclusief Monsin

    • Sluis Nooordervaart: reverse flow-direction
    • Integeal en proportional moeten positief zijn Pid Controllers behalve voor node_id=1000009 (beiden negatief laten), ziein D2306.LHM_RIBASIM\02.brongegevens\Rijkswaterstaat\modellen\hws_sturing\cases\database.gpkg
    • Pid Control Hengelo (node_id=1000007) moet luisteren naar node_id=10519 (Check bovenstroomse basin)
  • Pid Control Delden (node_id=1000006) moet luisteren naar node_id 10570 (Check boevenstroomse basin)

  • Netwerk tak: 75 krijgt negatieve flow. Zit ook raar verbonden met 74. Mag dit?

  • Pid Control Haringvlietsluizen voert ongeveer 200m3/s af bij een inflow van Lobith op 2750m3/s. Dit zou meer moeten zijn.

  • Prins Bernhardsluizen Discrete control condition werkt niet

  • Irenesluizen Discrete control condition werkt niet

  • Discrete control logic moet met F beginnen. Gaat fout bij node_id: 1000001 en 1000002

Required functions

  • clip model by polygon
  • update state by polygon
  • remove node
  • change node type
  • volume-courant
  • reverse flow direction
@visr
Copy link
Member

visr commented Apr 17, 2024

Deltares/Ribasim#1393 may be relevant for DiscreteControl related issues.

@DanielTollenaar DanielTollenaar moved this from 🏗 In progress to 🔖 Ready in Ribasim NL Aug 16, 2024
@DanielTollenaar DanielTollenaar added the RWS-HWS Issues in RWS-HWS model label Jan 6, 2025
@DanielTollenaar DanielTollenaar moved this from 🔖 Ready to 📋 Backlog in Ribasim NL Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
RWS-HWS Issues in RWS-HWS model
Projects
Status: 📋 Backlog
Development

No branches or pull requests

3 participants