Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix HWS model TabulatedRatingCurve with new Ribasim checks #89

Closed
SouthEndMusic opened this issue May 27, 2024 · 2 comments
Closed

Fix HWS model TabulatedRatingCurve with new Ribasim checks #89

SouthEndMusic opened this issue May 27, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@SouthEndMusic
Copy link

TabulatedRatingCurve has some new checks built in in the core (see here), which make the HWS model fail:

┌ Error: The `flow_rate` cannot decrease with increasing `level`.
│   node_id = TabulatedRatingCurve #37
└ @ Ribasim c:\Users\konin_bt\Ribasim_development\Ribasim\core\src\validation.jl:431
┌ Error: The `flow_rate` cannot decrease with increasing `level`.
│   node_id = TabulatedRatingCurve #49
└ @ Ribasim c:\Users\konin_bt\Ribasim_development\Ribasim\core\src\validation.jl:431
┌ Error: The `flow_rate` must start at 0.
│   node_id = TabulatedRatingCurve #88
│   flow_rate = 685.6
└ @ Ribasim c:\Users\konin_bt\Ribasim_development\Ribasim\core\src\validation.jl:421
┌ Error: The `flow_rate` must start at 0.
│   node_id = TabulatedRatingCurve #148
│   flow_rate = 125.4
└ @ Ribasim c:\Users\konin_bt\Ribasim_development\Ribasim\core\src\validation.jl:421
@SouthEndMusic SouthEndMusic changed the title Fix HWS modle TabulatedRatingCurve with new Ribasim checks Fix HWS model TabulatedRatingCurve with new Ribasim checks May 27, 2024
@visr visr added the bug Something isn't working label May 27, 2024
@DanielTollenaar
Copy link
Collaborator

On one hand; logical choice not to accept it in the solver. On the other; now we need to put complex discharge/supply-controls in multiple links with controllers. Let's discuss 28/8 how (to keep it as simple as possible).

@visr
Copy link
Member

visr commented Nov 26, 2024

Pretty sure this is fixed now.

@visr visr closed this as completed Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants