From 7d472b7fe68c4ccb8a1e5f9c32e0aa4c370d7658 Mon Sep 17 00:00:00 2001
From: Martijn Visser <mgvisser@gmail.com>
Date: Fri, 2 Feb 2024 09:22:26 +0100
Subject: [PATCH] Stop running CompatHelper on root project again (#1063)

In #1021 I enabled to run CompatHelper on the root project, but seeing
the flood of PRs this morning and thinking about it some more, I think
this was a mistake. We should close all those PRs.

Compat is needed in core for all dependencies. For other dependencies,
in principle we shouldn't declare compat, since we use a Manifest
anyway. This is similar to the way we allow any version in pixi.toml,
and the monthly pixi.lock update also brings in possibly breaking
changes that we can then evaluate.

We could have compat entries in the root project. Those makes sense if
we are not compatible with newer breaking releases to hold it back. This
way the manifest update will not bring in this incompatible release. We
should not forget about these, so ideally we have an issue labeled
`tech-debt` for those.
---
 .github/workflows/core_compat_helper.yml |  5 +----
 Project.toml                             | 22 ----------------------
 2 files changed, 1 insertion(+), 26 deletions(-)

diff --git a/.github/workflows/core_compat_helper.yml b/.github/workflows/core_compat_helper.yml
index c2e96be0f..ac35110da 100644
--- a/.github/workflows/core_compat_helper.yml
+++ b/.github/workflows/core_compat_helper.yml
@@ -37,10 +37,7 @@ jobs:
       - name: "Run CompatHelper"
         run: |
           import CompatHelper
-          CompatHelper.main(; subdirs=[
-              ".",
-              "core",
-          ])
+          CompatHelper.main(; subdirs=["core"])
         shell: julia --color=yes {0}
         env:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
diff --git a/Project.toml b/Project.toml
index 7c06c834c..8ba521efb 100644
--- a/Project.toml
+++ b/Project.toml
@@ -55,25 +55,3 @@ TestEnv = "1e6cf692-eddd-4d53-88a5-2d735e33781b"
 TimeZones = "f269a46b-ccf7-5d73-abea-4c690281aa53"
 TimerOutputs = "a759f4b9-e2f1-59dc-863e-4aeb61b1ea8f"
 TranscodingStreams = "3bb67fe8-82b1-5028-8e26-92a6c54297fa"
-
-[compat]
-Artifacts = "<0.0.1,1"
-BasicModelInterface = "0.1"
-Configurations = "0.17"
-DataFrames = "1"
-Dates = "<0.0.1,1"
-Documenter = "0.27,1"
-DocumenterMarkdown = "0.2"
-IJulia = "1"
-InteractiveUtils = "<0.0.1,1"
-JSON3 = "1.12"
-Legolas = "0.5"
-LibGit2 = "<0.0.1,1"
-Logging = "<0.0.1,1"
-MarkdownTables = "1"
-OrderedCollections = "1.6"
-PackageCompiler = "2"
-TOML = "<0.0.1,1"
-TerminalLoggers = "0.1.7"
-TimeZones = "=1.14.0, 1"
-julia = "1.10"