-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add user.realized
and expose via BMI
#1098
Labels
Comments
SouthEndMusic
added
needs-refinement
Issues that are too large and need refinement
allocation
Allocation layer
labels
Feb 8, 2024
We should be able to use the same method as the one required for #935. |
SouthEndMusic
removed
the
needs-refinement
Issues that are too large and need refinement
label
Feb 14, 2024
visr
added a commit
that referenced
this issue
Feb 29, 2024
Fixes #1098. @visr @HendrikKok would it be OK if `realized` is not an average but a cumulative volume and resetting it to `0.0` is the responsibility of the coupler? Otherwise we need a discussion about where in the Ribasim code these things must happen in such a way that dividing by the time interval happens before `realized` is accessed and resetting afterwards. Also good to know that `demand` is per user per priority, but `realized` is only per user. **For BMI variable name upgrade instructions see:** https://github.com/Deltares/Ribasim/pull/1190/files#diff-88d699c34d26c16edb268bdacbda2afb8dad704b8db2931a83e04b9ca52dc31a. --------- Co-authored-by: Martijn Visser <mgvisser@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
What
#1081 exposes a flat user demand vector via the BMI. As mentioned in #893, a realized average abstraction from the users is also needed in the BMI for coupling.
How
Add a field
user.realized::Vector{Float64}
with the realized flow per user over the required timestep (?). To keep it general, return flow should be taken into account, so that the realized flow should be the average of the difference between the abstraction and the return flow.The text was updated successfully, but these errors were encountered: