Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add user.realized and expose via BMI #1098

Closed
SouthEndMusic opened this issue Feb 8, 2024 · 1 comment · Fixed by #1190
Closed

Add user.realized and expose via BMI #1098

SouthEndMusic opened this issue Feb 8, 2024 · 1 comment · Fixed by #1190
Assignees
Labels
allocation Allocation layer coupling Coupling to other models

Comments

@SouthEndMusic
Copy link
Collaborator

What
#1081 exposes a flat user demand vector via the BMI. As mentioned in #893, a realized average abstraction from the users is also needed in the BMI for coupling.

How
Add a field user.realized::Vector{Float64} with the realized flow per user over the required timestep (?). To keep it general, return flow should be taken into account, so that the realized flow should be the average of the difference between the abstraction and the return flow.

@SouthEndMusic SouthEndMusic added needs-refinement Issues that are too large and need refinement allocation Allocation layer labels Feb 8, 2024
@github-project-automation github-project-automation bot moved this to To do in Ribasim Feb 8, 2024
@visr
Copy link
Member

visr commented Feb 8, 2024

We should be able to use the same method as the one required for #935.

@SouthEndMusic SouthEndMusic removed the needs-refinement Issues that are too large and need refinement label Feb 14, 2024
@SnippenE SnippenE moved this from To do to What's next in Ribasim Feb 15, 2024
@SnippenE SnippenE added the coupling Coupling to other models label Feb 15, 2024
@gijsber gijsber moved this from What's next to Sprint backlog in Ribasim Feb 27, 2024
@SouthEndMusic SouthEndMusic moved this from Sprint backlog to 👀 In review in Ribasim Feb 28, 2024
visr added a commit that referenced this issue Feb 29, 2024
Fixes #1098.

@visr @HendrikKok would it be OK if `realized` is not an average but a
cumulative volume and resetting it to `0.0` is the responsibility of the
coupler? Otherwise we need a discussion about where in the Ribasim code
these things must happen in such a way that dividing by the time
interval happens before `realized` is accessed and resetting afterwards.

Also good to know that `demand` is per user per priority, but `realized`
is only per user.

**For BMI variable name upgrade instructions see:**


https://github.com/Deltares/Ribasim/pull/1190/files#diff-88d699c34d26c16edb268bdacbda2afb8dad704b8db2931a83e04b9ca52dc31a.

---------

Co-authored-by: Martijn Visser <mgvisser@gmail.com>
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in Ribasim Feb 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
allocation Allocation layer coupling Coupling to other models
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants