Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add supply/demands for basins in allocation to allocation.arrow output #1122

Closed
SouthEndMusic opened this issue Feb 14, 2024 · 1 comment · Fixed by #1148
Closed

Add supply/demands for basins in allocation to allocation.arrow output #1122

SouthEndMusic opened this issue Feb 14, 2024 · 1 comment · Fixed by #1148
Labels
allocation Allocation layer

Comments

@SouthEndMusic
Copy link
Collaborator

SouthEndMusic commented Feb 14, 2024 •
edited
Loading

What
The supply/demand of basins is computed (since #1082) but never stored. I propose to store this information in the allocation.arrow output file. It fits in there quite well, apart from that the column name user_node_id must be generalized to something that encompasses all nodes that have a demand.

For testing, expand on @testitem "Allocation level control". Also add a test for stage 5 of the graph in #1082 (comment).
@SouthEndMusic SouthEndMusic added the allocation Allocation layer label Feb 14, 2024
@github-project-automation github-project-automation bot moved this to To do in Ribasim Feb 14, 2024
@visr
Copy link
Member

visr commented Feb 14, 2024

It fits in there quite well, apart from that the column name user_node_id must be generalized to something that encompasses all nodes that have a demand.

Sounds like the combination of node_type and node_id will do, in light of #1113.

@SnippenE SnippenE moved this from To do to What's next in Ribasim Feb 15, 2024
@SouthEndMusic SouthEndMusic moved this from What's next to 🏗 In progress in Ribasim Feb 19, 2024
@SouthEndMusic SouthEndMusic mentioned this issue Feb 19, 2024
Merged
visr pushed a commit that referenced this issue Feb 21, 2024
@SouthEndMusic
Basin allocation output (#1148)
8a0488e 
Fixes #1122.

# Upgrade information

The flow rate in `flow.arrow` is now in a column named `flow_rate`
rather than `flow` to be consistent with the input.
@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in Ribasim Feb 21, 2024
Hofer-Julian pushed a commit that referenced this issue Feb 22, 2024
@SouthEndMusic @Hofer-Julian
Basin allocation output (#1148)
5981a18 
Fixes #1122.

# Upgrade information

The flow rate in `flow.arrow` is now in a column named `flow_rate`
rather than `flow` to be consistent with the input.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
allocation Allocation layer
Projects
Ribasim
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Basin allocation output Deltares/Ribasim
2 participants
@visr @SouthEndMusic