-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix allocation flow output #1206
Labels
allocation
Allocation layer
Comments
This should be fixed before #1066 |
SnippenE
added
bug
External request
Feature requests or improvements from external users
labels
Apr 3, 2024
SouthEndMusic
removed
the
External request
Feature requests or improvements from external users
label
Apr 4, 2024
@SnippenE this is not the issue about the allocation output discussed at the last samenwerkingsdag. That one is already fixed: #1347. There are 2 different allocation output files: https://deltares.github.io/Ribasim/core/usage.html#allocation---allocation.arrow |
visr
added a commit
that referenced
this issue
Apr 4, 2024
Fixes #1206. --------- Co-authored-by: Martijn Visser <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
What
It seems that there are some problems with the allocation flow output in
allocation_flow.arrow
:realized
. In the case of level demand, use the difference in storage between the beginning and the end of the basin. Moved to new issue: Use average flows over allocation intervals forrealized
inallocation.arrow
#1356How
Per task above in
save_allocation_flows!
:graph[].flow_dict
(or is such a lookup unnecessarily slow?);graph[].edge_ids[allocation_network_id]
and thus also in the index set ofproblem[:F]
which is looped over insave_allocation_flows!
.integrate_flows!
for the flows that are relevant for this allocation input, stored somewhere in the allocation data structure (make sure that this goes well in subnetworks where all optimizations are run twice.). For the storage difference: use the currentu
and the previous one which can be taken from theintegrator
object (which is available in theupdate_allocation!
function).The text was updated successfully, but these errors were encountered: