Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge PoC Delwaq coupling scripts #1266

Closed
3 tasks
evetion opened this issue Mar 14, 2024 · 3 comments
Closed
3 tasks

Merge PoC Delwaq coupling scripts #1266

evetion opened this issue Mar 14, 2024 · 3 comments
Assignees
Labels
coupling Coupling to other models waterquality Issues related to Delwaq coupling/functionality

Comments

@evetion
Copy link
Member

evetion commented Mar 14, 2024

The current scripts are still low quality, but do reference existing tables/code that we should test by doing an integration test.

  • Make pixi Python environment for coupling
  • Create integration test that runs the coupling/delwaq/gen_delwaq.py script.
  • Write Ribasim results direct into pointer tabel
@evetion evetion added this to Ribasim Mar 14, 2024
@evetion evetion converted this from a draft issue Mar 14, 2024
@evetion evetion added coupling Coupling to other models waterquality Issues related to Delwaq coupling/functionality labels Mar 14, 2024
@visr
Copy link
Member

visr commented Mar 14, 2024

What is the benefit of a separate pixi environment for this rather than the default one?

@evetion
Copy link
Member Author

evetion commented Mar 14, 2024

For developer purposes it can go into the main one. I was thinking of having coupling as an optional feature to ribasim python you can install with pip, like pip install ribasim[coupling] Not sure if that would align with pixi yet.

@SouthEndMusic SouthEndMusic moved this from Sprint backlog to What's next in Ribasim Apr 23, 2024
@evetion evetion moved this from What's next to 🏗 In progress in Ribasim May 7, 2024
@evetion evetion moved this from 🏗 In progress to ✅ Done in Ribasim May 18, 2024
@evetion
Copy link
Member Author

evetion commented May 18, 2024

Closed by #1137

@evetion evetion closed this as completed May 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
coupling Coupling to other models waterquality Issues related to Delwaq coupling/functionality
Projects
Archived in project
Development

No branches or pull requests

2 participants