Node ID numbering changes mean imod-qgis timeseries plot doesn't fetch the right data

[Huite]

Previously, the node feature ID was equal to the node_id. This meant that we could directly use the feature id to locate timeseries in the result dataframes.

Because node_id is no identical to the feature ID, the timeseries plot will either not find the results (because the FID doesn't exists as a node_id), or it will show the wrong timeseries.

It only goes well if your model node_id matches the feature ID as before.

[visr]

Do you see this going wrong?

I thought the code was already adopted for this:

Ribasim/ribasim_qgis/widgets/dataset_widget.py

Lines 321 to 329 in f43010b

	def __set_node_results(self) -> None:
	node_layer = self.ribasim_widget.node_layer
	assert node_layer is not None
	self.__set_results(node_layer, "node_id", "basin.arrow")
	def __set_edge_results(self) -> None:
	edge_layer = self.ribasim_widget.edge_layer
	assert edge_layer is not None
	self.__set_results(edge_layer, "edge_id", "flow.arrow")

[Huite]

I think you're referring to something else.

I mean these lines, essentially:

https://github.com/Deltares/imod-qgis/blob/e5f128c55ccf911289b8189d8bbf3411efa71569/imodqgis/timeseries/timeseries_widget.py#L569

https://github.com/Deltares/imod-qgis/blob/e5f128c55ccf911289b8189d8bbf3411efa71569/imodqgis/timeseries/timeseries_widget.py#L557

I don't think the keys match the feature IDs. I.e. we're creating a mapping of node_id => dataframe. Then we're searching for feature id's, which aren't node ID's.

The reason I mention this is because I was getting weird selections.

[visr]

Ok right, so in imod-qgis there are the implicit assumptions that node_id == fid for basin.arrow and edge_id == fid for flow.arrow. The latter is currently correct, though see #1310. The former is incorrect.

[Huite]

Indeed.

I think the unfortunate thing is it required imod-qgis changes, and a new release of the plugin for people to use it.

[visr]

Yeah it's quite bad. How about #1316 as a temporary fix?

[Huite]

Fixed by this: Deltares/imod-qgis#79