-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use a dummy CRS instead of the Dutch CRS in ribasim testmodels #1362
Comments
There is no EPSG for this? I feel like having such a long code in the TOML that is often used as example is worse. |
That's the engineering part of the datum, cartesian (x, y) in an imaginery space somewhere. There's no EPSG code for it, apart from some deprecated example ones (EPSG:5806 comes to mind) I agree it's ugly, but I would prefer it over being wrong 😄. And this is a logical extension from the crs PR, or would you want to limit it to EPSG codes only? |
I don't necessarily want to limit it to EPSG codes only, though we should stimulate people to use them when possible.
I prefer wrong, since wrong only affects plotting it on the map. We cannot plot it on any base map since the locations don't exist. Perhaps EPSG:5806 is fine to use? Strange that it is deprecated with no alternative. |
Let's revisit when a suitable dummy EPSG is added ;) |
#1339 added setting crs to our models, and made it mandatory to do so. Now all of our testmodels have EPSG:28992 set (the Dutch crs), but points are actually set with local coordinates like point(0,0) (https://github.com/Deltares/Ribasim/blob/main/python/ribasim_testmodels/ribasim_testmodels/allocation.py#L36).
Arguably, we need to set a dummy engineering crs for these models, like:
#nitpick
The text was updated successfully, but these errors were encountered: