Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename "Python Lint" to "Mypy" and "python_lint.yml" to "mypy.yml" #1376

Closed
Jingru923 opened this issue Apr 11, 2024 · 0 comments · Fixed by #1377
Closed

Rename "Python Lint" to "Mypy" and "python_lint.yml" to "mypy.yml" #1376

Jingru923 opened this issue Apr 11, 2024 · 0 comments · Fixed by #1377
Assignees
Labels
CI/CD Continuous Integration/Continuous deployment

Comments

@Jingru923
Copy link
Contributor

What
We have a pipeline has a name that is not clear enough to show its functionality.

Why
The pipeline is named as Python Lint and the yaml file is named "python_lint.yml". Python lint in general check the error in the code and modify the code automatically based on the code standard. However, we only use one function called Mypy in the pipeline because this is not able to be done during the pre-commit check while other linting activities are done during the pre-commit check. As the name of the pipeline need to show the functionality in a direct way, having the pipeline named Lint is confusing.

How
As the title suggests, change the name "Python Lint" to "Mypy" and "python_lint.yml" to "mypy.yml".

@Jingru923 Jingru923 self-assigned this Apr 11, 2024
@github-project-automation github-project-automation bot moved this to To do in Ribasim Apr 11, 2024
@Jingru923 Jingru923 moved this from To do to 🏗 In progress in Ribasim Apr 11, 2024
@Jingru923 Jingru923 added the CI/CD Continuous Integration/Continuous deployment label Apr 11, 2024
@Jingru923 Jingru923 linked a pull request Apr 11, 2024 that will close this issue
Jingru923 added a commit that referenced this issue Apr 11, 2024
Fixes #1376 renamed python lint to mypy in pipeline
@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in Ribasim Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/CD Continuous Integration/Continuous deployment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant