Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use same network for allocation and flow #1388

Closed
visr opened this issue Apr 15, 2024 · 0 comments · Fixed by #1399
Closed

Use same network for allocation and flow #1388

visr opened this issue Apr 15, 2024 · 0 comments · Fixed by #1399
Assignees
@SouthEndMusic
Labels
allocation Allocation layer core Issues related to the computational core in Julia

Comments

@visr
Copy link
Member

visr commented Apr 15, 2024 •
edited
Loading

Currently allocation is using a derived network that only takes in features that matter for allocation. That means we need to map back and forth. The allocation code will be more maintainable if we stick to a 1:1 mapping. This will also help with implementing #714.

For Terminals we can add a 0 flow constraint instead of pruning the branch.
@github-project-automation github-project-automation bot moved this to To do in Ribasim Apr 15, 2024
@visr visr added allocation Allocation layer core Issues related to the computational core in Julia improvement labels Apr 15, 2024
@SouthEndMusic SouthEndMusic moved this from To do to 🏗 In progress in Ribasim Apr 16, 2024
@SouthEndMusic SouthEndMusic mentioned this issue Apr 17, 2024
Merged
@SouthEndMusic SouthEndMusic self-assigned this Apr 18, 2024
SouthEndMusic added a commit that referenced this issue Apr 22, 2024
@SouthEndMusic
Use the same network for allocation as for the physical layer (#1399)
e3bf329 
Fixes #1388.

This also fixes a bug I found: In allocation the `max_flow_rate` of a
node connecting the main network to a subnetwork was not taken into
account
@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in Ribasim Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SouthEndMusic SouthEndMusic

Labels
allocation Allocation layer core Issues related to the computational core in Julia
Projects
Ribasim
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use the same network for allocation as for the physical layer Deltares/Ribasim
2 participants
@visr @SouthEndMusic